Skip to content

Sample builds failed because the cleanup_old_sinks method failed to clean up sink-storage sinks #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cindy-peng opened this issue Apr 16, 2025 · 0 comments · May be fixed by #991
Open

Sample builds failed because the cleanup_old_sinks method failed to clean up sink-storage sinks #987

cindy-peng opened this issue Apr 16, 2025 · 0 comments · May be fixed by #991
Assignees
@gkevinzheng
Labels
api: logging Issues related to the googleapis/python-logging API.

Comments

@cindy-peng
Copy link
Contributor

We have observed sample build job failures on all different python versions for the pull requests. This is likely caused by cleanup_old_sinks method failing to clean up some of the storage sinks. We found storage sinks sink-storage- still exists after the clean up job.

We've temporarily resolved the issue by manually deleting the sinks, and subsequent sample builds are now passing. This work item tracks the failure of cleanup_old_sinks to remove storage sinks.
@cindy-peng cindy-peng self-assigned this Apr 16, 2025
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Apr 16, 2025
@cindy-peng cindy-peng assigned gkevinzheng and unassigned bhshkh and cindy-peng Apr 16, 2025
@cindy-peng cindy-peng changed the title Sample builds failed due to cleanup_old_sinks method fail to clean up sink-storage-** sinks Sample builds failed because the cleanup_old_sinks method failed to clean up sink-storage sinks Apr 16, 2025
@gkevinzheng gkevinzheng linked a pull request Apr 21, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkevinzheng gkevinzheng

Labels
api: logging Issues related to the googleapis/python-logging API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Added cleanup of old sink storage buckets googleapis/python-logging
3 participants
@bhshkh @gkevinzheng @cindy-peng