Skip to content

Commit 5d7a63f

Browse files
dpebotplamut
authored andcommitted
Auto-update dependencies. [(#922)](GoogleCloudPlatform/python-docs-samples#922)
* Auto-update dependencies. * Fix pubsub iam samples
1 parent d0666b1 commit 5d7a63f

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

samples/snippets/iam.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,11 @@ def set_topic_policy(topic_name):
6767
policy = topic.get_iam_policy()
6868

6969
# Add all users as viewers.
70-
policy.viewers.add(policy.all_users())
71-
# Add a group as editors.
72-
policy.editors.add(policy.group('[email protected]'))
70+
policy['roles/pubsub.viewer'] = [policy.all_users()]
71+
# Add a group as publisherss.
72+
publishers = policy.get('roles/pubsub.publisher', [])
73+
publishers.append(policy.group('[email protected]'))
74+
policy['roles/pubsub.publisher'] = publishers
7375

7476
# Set the policy
7577
topic.set_iam_policy(policy)
@@ -85,9 +87,11 @@ def set_subscription_policy(topic_name, subscription_name):
8587
policy = subscription.get_iam_policy()
8688

8789
# Add all users as viewers.
88-
policy.viewers.add(policy.all_users())
89-
# Add a group as editors.
90-
policy.editors.add(policy.group('[email protected]'))
90+
policy['roles/viewer'] = [policy.all_users()]
91+
# # Add a group as editors.
92+
editors = policy.get('roles/editor', [])
93+
editors.append(policy.group('[email protected]'))
94+
policy['roles/editor'] = editors
9195

9296
# Set the policy
9397
subscription.set_iam_policy(policy)

samples/snippets/iam_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def test_set_topic_policy(test_topic):
6767

6868
policy = test_topic.get_iam_policy()
6969
assert policy.viewers
70-
assert policy.editors
70+
assert policy['roles/pubsub.publisher']
7171

7272

7373
def test_set_subscription_policy(test_subscription):

samples/snippets/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
google-cloud-pubsub==0.24.0
1+
google-cloud-pubsub==0.25.0

0 commit comments

Comments
 (0)