-
Notifications
You must be signed in to change notification settings - Fork 30
feat: Stage 6 of nox
implementation - enabling system tests
#480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nox
implementation - enabling system testsnox
implementation - enabling system tests
noxfile.py
Outdated
# virtualenv's dist-packages. | ||
session.install("mock", "pytest") | ||
session.install("-e", ".") | ||
session.install("-e", "test_utils") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If any of the system tests need the contents of test_utils, you can install it through pip.
It might not be necessary though (there's not too much in it (https://github.com/googleapis/python-test-utils/tree/master/test_utils) at this point.
pip install google-cloud-testutils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@busunkim96 👍 Agreed. This way used to be prevalent across other products and still exists in Spanner, Bigtable, and possibly some others. Would it be a good idea to update those as well?
Add googleapis/python-test-utils and system test stub
As suggested in #466 , this represents the last item of the recommended list aimed to implement nox testing automation in multiple steps.
Change list:
test_utils
package directory;system
test session to Nox configuration;tests/system/test_system.py
template file;.gitignore
file.A dummy test method inside the template file is necessary to avoid an
exit code 5
error, that is when no tests get collected.Session test log:
Towards #474.