-
Notifications
You must be signed in to change notification settings - Fork 30
feat: Add open telemetry trace in schema and related unit tests #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chore: add a Code of Conduct (googleapis#604)
fix: lint_setup_py was failing in Kokoro is now fixed (googleapis#607)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I'm not very familiar with Django usage.
For CloudSpannerDjango.alter_field
, I noticed that the method is _alter_field
. Should the trace reflect this? Do users call this directly?
users are not going to call this method directly, this trace is added more for keeping track. Wherever calls to backend takes place then how long those calls are taking. |
Add tracing in schema with related checks in unit tests.
Fixes #633 🦕