feat: raise exceptions for ESCAPE keyword (#64)

Author: Ilya Gurov

google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py

@@ -137,6 +137,17 @@ def visit_empty_set_expr(self, type_):
             _type_map_inv[type(type_[0])]
         )
 
+    def visit_like_op_binary(self, binary, operator, **kw):
+        """Build a LIKE clause."""
+        if binary.modifiers.get("escape", None):
+            raise NotImplementedError("ESCAPE keyword is not supported by Spanner")
+
+        # TODO: use ternary here, not "and"/ "or"
+        return "%s LIKE %s" % (
+            binary.left._compiler_dispatch(self, **kw),
+            binary.right._compiler_dispatch(self, **kw),
+        )
+
     def render_literal_value(self, value, type_):
         """Render the value of a bind parameter as a quoted literal.
 

test/test_suite.py

@@ -1326,42 +1326,48 @@ def test_enotation_decimal(self):
 
 
 class LikeFunctionsTest(_LikeFunctionsTest):
-    @pytest.mark.skip("Spanner does not support ESCAPE")
+    @pytest.mark.skip("Spanner doesn't support LIKE ESCAPE clause")
     def test_contains_autoescape(self):
         pass
 
-    @pytest.mark.skip("Spanner does not support ESCAPE")
+    @pytest.mark.skip("Spanner doesn't support LIKE ESCAPE clause")
     def test_contains_autoescape_escape(self):
         pass
 
-    @pytest.mark.skip("Spanner does not support ESCAPE")
+    @pytest.mark.skip("Spanner doesn't support LIKE ESCAPE clause")
     def test_contains_escape(self):
         pass
 
-    @pytest.mark.skip("Spanner does not support ESCAPE")
+    @pytest.mark.skip("Spanner doesn't support LIKE ESCAPE clause")
     def test_endswith_autoescape(self):
         pass
 
-    @pytest.mark.skip("Spanner does not support ESCAPE")
+    @pytest.mark.skip("Spanner doesn't support LIKE ESCAPE clause")
     def test_endswith_escape(self):
         pass
 
-    @pytest.mark.skip("Spanner does not support ESCAPE")
+    @pytest.mark.skip("Spanner doesn't support LIKE ESCAPE clause")
     def test_endswith_autoescape_escape(self):
         pass
 
-    @pytest.mark.skip("Spanner does not support ESCAPE")
+    @pytest.mark.skip("Spanner doesn't support LIKE ESCAPE clause")
     def test_startswith_autoescape(self):
         pass
 
-    @pytest.mark.skip("Spanner does not support ESCAPE")
+    @pytest.mark.skip("Spanner doesn't support LIKE ESCAPE clause")
     def test_startswith_escape(self):
         pass
 
-    @pytest.mark.skip("Spanner does not support ESCAPE")
+    @pytest.mark.skip("Spanner doesn't support LIKE ESCAPE clause")
     def test_startswith_autoescape_escape(self):
         pass
 
+    def test_escape_keyword_raises(self):
+        """Check that ESCAPE keyword causes an exception when used."""
+        with pytest.raises(NotImplementedError):
+            col = self.tables.some_table.c.data
+            self._test(col.contains("b##cde", escape="#"), {7})
+
 
 @pytest.mark.skip("Spanner doesn't support quotes in table names.")
 class QuotedNameArgumentTest(_QuotedNameArgumentTest):