From f687c129025c43c848a095391bd9d91a4a8daf76 Mon Sep 17 00:00:00 2001 From: Mohammed Mansoor Ahmed <5281125+mmahmed@users.noreply.github.com> Date: Mon, 22 Apr 2024 17:01:09 +0530 Subject: [PATCH] fix: Index on a table containing columns with no sort order fails while reflecting the table Fixes: 1. Ignore None order as SQLAlchemy only processes ASC, DESC 2. SQLAlchemy requires order in lowercase (asc, desc) --- google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py b/google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py index 168de44d..93a8ba69 100644 --- a/google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py +++ b/google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py @@ -1011,7 +1011,9 @@ def get_multi_indexes( "column_names": row[3], "unique": row[4], "column_sorting": { - col: order for col, order in zip(row[3], row[5]) + col: order.lower() + for col, order in zip(row[3], row[5]) + if order is not None }, } row[0] = row[0] or None