Skip to content

Commit 25a6ec0

Browse files
committed
nit fixes
1 parent 027e0b1 commit 25a6ec0

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

docs/opentelemetry-tracing.rst

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ We also need to tell OpenTelemetry which exporter to use. For example, to export
2121
# in a seperate thread to not block on the main thread
2222
from opentelemetry.sdk.trace.export import BatchExportSpanProcessor
2323
24-
# create and export one trace every 1000 requests
24+
# Create and export one trace every 1000 requests
2525
sampler = ProbabilitySampler(1/1000)
26-
# Uses the default tracer provider
26+
# Use the default tracer provider
2727
trace.set_tracer_provider(TracerProvider(sampler=sampler))
2828
trace.get_tracer_provider().add_span_processor(
29-
# initialize the cloud tracing exporter
29+
# Initialize the cloud tracing exporter
3030
BatchExportSpanProcessor(CloudTraceSpanExporter())
3131
)
3232

google/cloud/spanner_v1/_opentelemetry_tracing.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@
3232
@contextmanager
3333
def trace_call(name, session, extra_attributes=None):
3434
if not HAS_OPENTELEMETRY_INSTALLED or not session:
35-
# empty context manager. users will have to check if the generated value is None or a span
35+
# Empty context manager. Users will have to check if the generated value is None or a span
3636
yield None
3737
return
3838

3939
tracer = trace.get_tracer(__name__)
4040

41-
# base attributes that we know for every trace created
41+
# Set base attributes that we know for every trace created
4242
attributes = {
4343
"db.type": "spanner",
4444
"db.url": spanner_client.SpannerClient.SERVICE_ADDRESS,

tests/system/test_system.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -2513,7 +2513,7 @@ def test_execute_sql_returning_transfinite_floats(self):
25132513
)
25142514
)
25152515
self.assertEqual(len(rows), 1)
2516-
(float_array,) = rows[0]
2516+
float_array = rows[0]
25172517
self.assertEqual(float_array[0], float("-inf"))
25182518
self.assertEqual(float_array[1], float("+inf"))
25192519
# NaNs cannot be searched for by equality.

0 commit comments

Comments
 (0)