Skip to content

overly strict dependency on proto-plus #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tswast opened this issue Mar 17, 2021 · 2 comments · Fixed by #287
Closed

overly strict dependency on proto-plus #279

tswast opened this issue Mar 17, 2021 · 2 comments · Fixed by #287
Assignees
Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Contributor

tswast commented Mar 17, 2021

We noticed in building an internal tool that the Spanner dependency is much more strict than in other packages, such as BigQuery.

"proto-plus==1.14.2",

Since proto-plus is a core dependency of all client libraries, it is often bundled with an environment (e.g. in AI Platform Notebooks). The strict dependency makes it much harder to upgrade the google-cloud-spanner library in these environments.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Mar 17, 2021
@tswast
Copy link
Contributor Author

tswast commented Mar 17, 2021

Note: If the worry is incompatibilities with older versions, we do have a way of testing this. In BigQuery we do this with constraints files.

https://github.com/googleapis/python-bigquery/blob/7447f05f6a92bc4c047dff9d0377598b7af15f18/noxfile.py#L122

There is a PR in the works to use constraints files across all generated clients. googleapis/synthtool#869

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 18, 2021
@skuruppu skuruppu added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 19, 2021
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Mar 19, 2021
@larkee
Copy link
Contributor

larkee commented Mar 23, 2021

The strictness of the dependency came from an issue during the migration to v2.0 when I needed to pin to v1.10-dev2. It seems when I upgraded to 1.11.0 I kept the == rather than using >=. I've written a PR to update the dependency 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants