Skip to content

Add timeout to Backup.create() #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tmatsuo opened this issue Apr 27, 2020 · 2 comments
Closed

Add timeout to Backup.create() #67

tmatsuo opened this issue Apr 27, 2020 · 2 comments
Assignees
Labels
api: spanner Issues related to the googleapis/python-spanner API.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 27, 2020

The Backup API surface doesn't pass timeout to the underlining API call:

Can you add timeout param and pass it to the API call so that I can control the deadline? We occasionally see DeadlineExceededError upon Backup.create() calls.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Apr 27, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 27, 2020

Once #68 is done, this issue might be a moot.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 28, 2020
@larkee larkee added status: will not fix Invalid (untrue/unsound/erroneous), inconsistent with product, not on roadmap. and removed triage me I really want to be triaged. status: will not fix Invalid (untrue/unsound/erroneous), inconsistent with product, not on roadmap. labels Apr 29, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 29, 2020
@larkee
Copy link
Contributor

larkee commented Apr 29, 2020

Now that #68 has been fixed this shouldn't be necessary. However, it does highlight the lack of custom timeout and retry support we have through our surfaces. I'm going to close this issue and open a more general one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API.
Projects
None yet
Development

No branches or pull requests

3 participants