Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

Commit 3e8bd49

Browse files
authored
test: fix vpcsc tests (#54)
1 parent c4d7b47 commit 3e8bd49

File tree

1 file changed

+21
-17
lines changed

1 file changed

+21
-17
lines changed

tests/system/test_vpcsc.py

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,13 @@ def glossary_outside(glossary_name_outside):
7575

7676
@vpcsc_config.skip_unless_inside_vpcsc
7777
def test_create_glossary_w_inside(client, parent_inside, glossary_inside):
78-
client.create_glossary(parent_inside, glossary_inside)
78+
client.create_glossary(parent=parent_inside, glossary=glossary_inside)
7979

8080

8181
@vpcsc_config.skip_unless_inside_vpcsc
8282
def test_create_glossary_w_outside(client, parent_outside, glossary_outside):
8383
with pytest.raises(exceptions.PermissionDenied) as exc:
84-
client.create_glossary(parent_outside, glossary_outside)
84+
client.create_glossary(parent=parent_outside, glossary=glossary_outside)
8585

8686
assert exc.value.message.startswith(_VPCSC_PROHIBITED_MESSAGE)
8787

@@ -94,39 +94,39 @@ def test_list_glossaries_w_inside(client, parent_inside):
9494
@vpcsc_config.skip_unless_inside_vpcsc
9595
def test_list_glossaries_w_outside(client, parent_outside):
9696
with pytest.raises(exceptions.PermissionDenied) as exc:
97-
list(client.list_glossaries(parent_outside))
97+
list(client.list_glossaries(parent=parent_outside))
9898

9999
assert exc.value.message.startswith(_VPCSC_PROHIBITED_MESSAGE)
100100

101101

102102
@vpcsc_config.skip_unless_inside_vpcsc
103103
def test_get_glossary_w_inside(client, glossary_name_inside):
104104
try:
105-
client.get_glossary(glossary_name_inside)
105+
client.get_glossary(name=glossary_name_inside)
106106
except exceptions.NotFound: # no perms issue
107107
pass
108108

109109

110110
@vpcsc_config.skip_unless_inside_vpcsc
111111
def test_get_glossary_w_outside(client, glossary_name_outside):
112112
with pytest.raises(exceptions.PermissionDenied) as exc:
113-
client.get_glossary(glossary_name_outside)
113+
client.get_glossary(name=glossary_name_outside)
114114

115115
assert exc.value.message.startswith(_VPCSC_PROHIBITED_MESSAGE)
116116

117117

118118
@vpcsc_config.skip_unless_inside_vpcsc
119119
def test_delete_glossary_w_inside(client, glossary_name_inside):
120120
try:
121-
client.delete_glossary(glossary_name_inside)
121+
client.delete_glossary(name=glossary_name_inside)
122122
except exceptions.NotFound: # no perms issue
123123
pass
124124

125125

126126
@vpcsc_config.skip_unless_inside_vpcsc
127127
def test_delete_glossary_w_outside(client, glossary_name_outside):
128128
with pytest.raises(exceptions.PermissionDenied) as exc:
129-
client.delete_glossary(glossary_name_outside)
129+
client.delete_glossary(name=glossary_name_outside)
130130

131131
assert exc.value.message.startswith(_VPCSC_PROHIBITED_MESSAGE)
132132

@@ -140,11 +140,13 @@ def test_batch_translate_text_w_inside(client, parent_inside):
140140
"gcs_destination": {"output_uri_prefix": "gs://fake-bucket/output/"}
141141
}
142142
client.batch_translate_text( # no perms issue
143-
parent_inside,
144-
source_language_code,
145-
target_language_codes,
146-
input_configs,
147-
output_config,
143+
request={
144+
"parent": parent_inside,
145+
"source_language_code": source_language_code,
146+
"target_language_codes": target_language_codes,
147+
"input_configs": input_configs,
148+
"output_config": output_config,
149+
}
148150
)
149151

150152

@@ -158,11 +160,13 @@ def test_batch_translate_text_w_outside(client, parent_outside):
158160
}
159161
with pytest.raises(exceptions.PermissionDenied) as exc:
160162
client.batch_translate_text(
161-
parent_outside,
162-
source_language_code,
163-
target_language_codes,
164-
input_configs,
165-
output_config,
163+
request={
164+
"parent": parent_inside,
165+
"source_language_code": source_language_code,
166+
"target_language_codes": target_language_codes,
167+
"input_configs": input_configs,
168+
"output_config": output_config,
169+
}
166170
)
167171

168172
assert exc.value.message.startswith(_VPCSC_PROHIBITED_MESSAGE)

0 commit comments

Comments
 (0)