Skip to content

Build Cop: include enough information for making a report actionable #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shollyman opened this issue Feb 10, 2020 · 4 comments
Closed
Assignees
Labels
bot: flakybot type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@shollyman
Copy link

Sample issue filed by build cop: GoogleCloudPlatform/python-docs-samples#2800

It seems that the source log link is only available once all testing is concluded, so it's a bit confusing when it files issues that can't be acted on immediately. In this case, its four hours later and the bug is still unactionable as the build is still in progress

Consider adding a link for another source (e.g. sponge/sponge2) or deferring issue creation until the artifacts are ready.

@tbpg
Copy link
Contributor

tbpg commented Feb 10, 2020

The build URL is configured here: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/.kokoro/tests/run_tests.sh#L117

So, you can change it to whatever URL you prefer.

Perhaps we should allow more than one URL, that way we could have public and private links to logs?

@tbpg tbpg self-assigned this Feb 10, 2020
@tbpg tbpg added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 10, 2020
@shollyman
Copy link
Author

If we're able to generate multiple URLs, perhaps construct a history search URL as well so we can see the trend of a failing test over time (flakes, execution time, etc)?

@tbpg
Copy link
Contributor

tbpg commented Feb 10, 2020

You should theoretically be able to put markdown into the URL field -- I haven't tried it. But, you can almost definitely just do space-separated links and have it work.

If an issue gets closed and the test fails again, the bot will reopen the issue. So, I don't think we need a link for history.

@tbpg
Copy link
Contributor

tbpg commented Feb 20, 2020

I updated the logs field to include links to Build Status and Sponge. For example, see GoogleCloudPlatform/python-docs-samples#2894 (comment). Marking this as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: flakybot type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants