Skip to content

Commit 667f2da

Browse files
committed
chore: revert changes in gapic-generator-java
1 parent 8e221c1 commit 667f2da

File tree

4 files changed

+20
-20
lines changed

4 files changed

+20
-20
lines changed

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/common/RetrySettingsComposerTest.java

+13-13
Original file line numberDiff line numberDiff line change
@@ -121,18 +121,18 @@ public void paramDefinitionsBlock_basic() {
121121
"settings ="
122122
+ " RetrySettings.newBuilder().setInitialRetryDelay("
123123
+ "Duration.ofMillis(100L)).setRetryDelayMultiplier(2.0)"
124-
+ ".setMaxRetryDelay(java.time.Duration.ofMillis(3000L))"
125-
+ ".setInitialRpcTimeout(java.time.Duration.ofMillis(10000L))"
124+
+ ".setMaxRetryDelay(Duration.ofMillis(3000L))"
125+
+ ".setInitialRpcTimeout(Duration.ofMillis(10000L))"
126126
+ ".setRpcTimeoutMultiplier(1.0)"
127-
+ ".setMaxRpcTimeout(java.time.Duration.ofMillis(10000L))"
128-
+ ".setTotalTimeout(java.time.Duration.ofMillis(10000L)).build();\n",
127+
+ ".setMaxRpcTimeout(Duration.ofMillis(10000L))"
128+
+ ".setTotalTimeout(Duration.ofMillis(10000L)).build();\n",
129129
"definitions.put(\"retry_policy_1_params\", settings);\n",
130130
"settings ="
131131
+ " RetrySettings.newBuilder()"
132-
+ ".setInitialRpcTimeout(java.time.Duration.ofMillis(5000L))"
132+
+ ".setInitialRpcTimeout(Duration.ofMillis(5000L))"
133133
+ ".setRpcTimeoutMultiplier(1.0)"
134-
+ ".setMaxRpcTimeout(java.time.Duration.ofMillis(5000L))"
135-
+ ".setTotalTimeout(java.time.Duration.ofMillis(5000L)).build();\n",
134+
+ ".setMaxRpcTimeout(Duration.ofMillis(5000L))"
135+
+ ".setTotalTimeout(Duration.ofMillis(5000L)).build();\n",
136136
"definitions.put(\"no_retry_0_params\", settings);\n",
137137
"RETRY_PARAM_DEFINITIONS = definitions.build();\n",
138138
"}\n");
@@ -341,10 +341,10 @@ public void lroBuilderExpr() {
341341
+ "WaitResponse.class))"
342342
+ ".setMetadataTransformer(ProtoOperationTransformers.MetadataTransformer.create("
343343
+ "WaitMetadata.class)).setPollingAlgorithm(OperationTimedPollAlgorithm.create("
344-
+ "RetrySettings.newBuilder().setInitialRetryDelay(java.time.Duration.ofMillis(5000L))"
345-
+ ".setRetryDelayMultiplier(1.5).setMaxRetryDelay(java.time.Duration.ofMillis(45000L))"
346-
+ ".setInitialRpcTimeout(java.time.Duration.ZERO).setRpcTimeoutMultiplier(1.0)"
347-
+ ".setMaxRpcTimeout(java.time.Duration.ZERO).setTotalTimeout(java.time.Duration.ofMillis(300000L))"
344+
+ "RetrySettings.newBuilder().setInitialRetryDelay(Duration.ofMillis(5000L))"
345+
+ ".setRetryDelayMultiplier(1.5).setMaxRetryDelay(Duration.ofMillis(45000L))"
346+
+ ".setInitialRpcTimeout(Duration.ZERO).setRpcTimeoutMultiplier(1.0)"
347+
+ ".setMaxRpcTimeout(Duration.ZERO).setTotalTimeout(Duration.ofMillis(300000L))"
348348
+ ".build()))");
349349
assertEquals(expected, writerVisitor.write());
350350
}
@@ -394,7 +394,7 @@ public void batchingSettings_minimalFlowControlSettings() {
394394
+ "BatchingSettings.newBuilder()"
395395
+ ".setElementCountThreshold(100L)"
396396
+ ".setRequestByteThreshold(1048576L)"
397-
+ ".setDelayThreshold(java.time.Duration.ofMillis(10L))"
397+
+ ".setDelayThreshold(Duration.ofMillis(10L))"
398398
+ ".setFlowControlSettings("
399399
+ "FlowControlSettings.newBuilder()"
400400
+ ".setLimitExceededBehavior(FlowController.LimitExceededBehavior.Ignore)"
@@ -451,7 +451,7 @@ public void batchingSettings_fullFlowControlSettings() {
451451
+ "BatchingSettings.newBuilder()"
452452
+ ".setElementCountThreshold(1000L)"
453453
+ ".setRequestByteThreshold(1048576L)"
454-
+ ".setDelayThreshold(java.time.Duration.ofMillis(50L))"
454+
+ ".setDelayThreshold(Duration.ofMillis(50L))"
455455
+ ".setFlowControlSettings("
456456
+ "FlowControlSettings.newBuilder()"
457457
+ ".setMaxOutstandingElementCount(100000L)"

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/samplecode/SampleBodyJavaFormatterTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public void validFormatSampleCode_longChainMethod() {
4949
String sampleCode =
5050
"echoSettingsBuilder.echoSettings().setRetrySettings("
5151
+ "echoSettingsBuilder.echoSettings().getRetrySettings().toBuilder()"
52-
+ ".setTotalTimeout(java.time.Duration.ofSeconds(30)).build());";
52+
+ ".setTotalTimeout(Duration.ofSeconds(30)).build());";
5353
String result = SampleBodyJavaFormatter.format(sampleCode);
5454
String expected =
5555
LineFormatter.lines(
@@ -60,7 +60,7 @@ public void validFormatSampleCode_longChainMethod() {
6060
" .echoSettings()\n",
6161
" .getRetrySettings()\n",
6262
" .toBuilder()\n",
63-
" .setTotalTimeout(java.time.Duration.ofSeconds(30))\n",
63+
" .setTotalTimeout(Duration.ofSeconds(30))\n",
6464
" .build());");
6565
assertEquals(expected, result);
6666
}

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/samplecode/ServiceClientHeaderSampleComposerTest.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ public void composeClassHeaderSample_firstMethodIsNotUnaryRpc() {
163163
String expected =
164164
LineFormatter.lines(
165165
"try (EchoClient echoClient = EchoClient.create()) {\n",
166-
" java.time.Duration ttl =java.time.Duration.newBuilder().build();\n",
166+
" Duration ttl = Duration.newBuilder().build();\n",
167167
" WaitResponse response = echoClient.waitAsync(ttl).get();\n",
168168
"}");
169169
Assert.assertEquals(results, expected);
@@ -806,7 +806,7 @@ public void valid_composeShowcaseMethodSample_lroRpcWithReturnResponseType() {
806806
String expected =
807807
LineFormatter.lines(
808808
"try (EchoClient echoClient = EchoClient.create()) {\n",
809-
" java.time.Duration ttl =java.time.Duration.newBuilder().build();\n",
809+
" Duration ttl = Duration.newBuilder().build();\n",
810810
" WaitResponse response = echoClient.waitAsync(ttl).get();\n",
811811
"}");
812812
Assert.assertEquals(results, expected);
@@ -888,7 +888,7 @@ public void valid_composeShowcaseMethodSample_lroRpcWithReturnVoid() {
888888
String expected =
889889
LineFormatter.lines(
890890
"try (EchoClient echoClient = EchoClient.create()) {\n",
891-
" java.time.Duration ttl =java.time.Duration.newBuilder().build();\n",
891+
" Duration ttl = Duration.newBuilder().build();\n",
892892
" echoClient.waitAsync(ttl).get();\n",
893893
"}");
894894
Assert.assertEquals(results, expected);

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/samplecode/SettingsSampleComposerTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public void composeSettingsSample_serviceSettingsClass() {
6161
" .echoSettings()\n",
6262
" .getRetrySettings()\n",
6363
" .toBuilder()\n",
64-
" .setTotalTimeout(java.time.Duration.ofSeconds(30))\n",
64+
" .setTotalTimeout(Duration.ofSeconds(30))\n",
6565
" .build());\n",
6666
"EchoSettings echoSettings = echoSettingsBuilder.build();");
6767
assertEquals(results.get(), expected);
@@ -89,7 +89,7 @@ public void composeSettingsSample_serviceStubClass() {
8989
" .echoSettings()\n",
9090
" .getRetrySettings()\n",
9191
" .toBuilder()\n",
92-
" .setTotalTimeout(java.time.Duration.ofSeconds(30))\n",
92+
" .setTotalTimeout(Duration.ofSeconds(30))\n",
9393
" .build());\n",
9494
"EchoStubSettings echoSettings = echoSettingsBuilder.build();");
9595
assertEquals(results.get(), expected);

0 commit comments

Comments
 (0)