Skip to content

Commit 7cf57ca

Browse files
lqiu96lqiu96
committed
feat: Mark getDefaultEndpoint with @ObsoleteApi
1 parent 0cd9c0c commit 7cf57ca

File tree

33 files changed

+93
-46
lines changed

33 files changed

+93
-46
lines changed

‎gapic-generator-java/src/main/java/com/google/api/generator/engine/ast/AnnotationNode.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
package com.google.api.generator.engine.ast;
1616

17-
import com.google.api.core.ObsoleteApi;
1817
import com.google.auto.value.AutoValue;
1918
import com.google.common.base.Preconditions;
2019
import java.util.ArrayList;
@@ -28,8 +27,6 @@ public abstract class AnnotationNode implements AstNode {
2827
AnnotationNode.builder().setType(annotationType(Override.class)).build();
2928
public static AnnotationNode DEPRECATED =
3029
AnnotationNode.builder().setType(annotationType(Deprecated.class)).build();
31-
public static AnnotationNode OBSOLETE_API =
32-
AnnotationNode.builder().setType(annotationType(ObsoleteApi.class)).build();
3330

3431
private static TypeNode annotationType(Class<?> clazz) {
3532
return TypeNode.withReference(ConcreteReference.withClazz(clazz));

‎gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1189,7 +1189,13 @@ private List<MethodDefinition> createDefaultHelperAndGetterMethods(
11891189
.setReturnType(returnType)
11901190
.setName("getDefaultEndpoint")
11911191
.setReturnExpr(ValueExpr.withValue(StringObjectValue.withValue(service.defaultHost())))
1192-
.setAnnotations(ImmutableList.of(AnnotationNode.OBSOLETE_API))
1192+
.setAnnotations(
1193+
ImmutableList.of(
1194+
AnnotationNode.builder()
1195+
.setType(FIXED_TYPESTORE.get(ObsoleteApi.class.getSimpleName()))
1196+
.setDescription(
1197+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
1198+
.build()))
11931199
.build());
11941200

11951201
// Create the getDefaultMtlsEndpoint method.

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/DeprecatedServiceStubSettings.golden

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,8 @@ public class DeprecatedServiceStubSettings extends StubSettings<DeprecatedServic
109109
}
110110

111111
/** Returns the default service endpoint. */
112-
@ObsoleteApi
112+
@ObsoleteApi(
113+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
113114
public static String getDefaultEndpoint() {
114115
return "localhost:7469";
115116
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/EchoStubSettings.golden

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,8 @@ public class EchoStubSettings extends StubSettings<EchoStubSettings> {
292292
}
293293

294294
/** Returns the default service endpoint. */
295-
@ObsoleteApi
295+
@ObsoleteApi(
296+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
296297
public static String getDefaultEndpoint() {
297298
return "localhost:7469";
298299
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/LoggingServiceV2StubSettings.golden

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,8 @@ public class LoggingServiceV2StubSettings extends StubSettings<LoggingServiceV2S
435435
}
436436

437437
/** Returns the default service endpoint. */
438-
@ObsoleteApi
438+
@ObsoleteApi(
439+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
439440
public static String getDefaultEndpoint() {
440441
return "logging.googleapis.com:443";
441442
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/PublisherStubSettings.golden

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,8 @@ public class PublisherStubSettings extends StubSettings<PublisherStubSettings> {
444444
}
445445

446446
/** Returns the default service endpoint. */
447-
@ObsoleteApi
447+
@ObsoleteApi(
448+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
448449
public static String getDefaultEndpoint() {
449450
return "pubsub.googleapis.com:443";
450451
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpcrest/goldens/EchoStubSettings.golden

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,8 @@ public class EchoStubSettings extends StubSettings<EchoStubSettings> {
308308
}
309309

310310
/** Returns the default service endpoint. */
311-
@ObsoleteApi
311+
@ObsoleteApi(
312+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
312313
public static String getDefaultEndpoint() {
313314
return "localhost:7469";
314315
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpcrest/goldens/WickedStubSettings.golden

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,8 @@ public class WickedStubSettings extends StubSettings<WickedStubSettings> {
106106
}
107107

108108
/** Returns the default service endpoint. */
109-
@ObsoleteApi
109+
@ObsoleteApi(
110+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
110111
public static String getDefaultEndpoint() {
111112
return "localhost:7469";
112113
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/rest/goldens/ComplianceStubSettings.golden

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@ public class ComplianceStubSettings extends StubSettings<ComplianceStubSettings>
138138
}
139139

140140
/** Returns the default service endpoint. */
141-
@ObsoleteApi
141+
@ObsoleteApi(
142+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
142143
public static String getDefaultEndpoint() {
143144
return "localhost:7469";
144145
}

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/ComplianceStubSettings.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.api.core.ApiFunction;
2222
import com.google.api.core.ApiFuture;
2323
import com.google.api.core.BetaApi;
24+
import com.google.api.core.ObsoleteApi;
2425
import com.google.api.gax.core.GaxProperties;
2526
import com.google.api.gax.core.GoogleCredentialsProvider;
2627
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -279,6 +280,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
279280
}
280281

281282
/** Returns the default service endpoint. */
283+
@ObsoleteApi(
284+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
282285
public static String getDefaultEndpoint() {
283286
return "localhost:7469";
284287
}
@@ -516,7 +519,6 @@ private static Builder createDefault() {
516519
builder.setTransportChannelProvider(defaultTransportChannelProvider());
517520
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
518521
builder.setInternalHeaderProvider(defaultApiClientHeaderProviderBuilder().build());
519-
builder.setEndpoint(getDefaultEndpoint());
520522
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
521523
builder.setSwitchToMtlsEndpointAllowed(true);
522524

@@ -529,7 +531,6 @@ private static Builder createHttpJsonDefault() {
529531
builder.setTransportChannelProvider(defaultHttpJsonTransportProviderBuilder().build());
530532
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
531533
builder.setInternalHeaderProvider(defaultHttpJsonApiClientHeaderProviderBuilder().build());
532-
builder.setEndpoint(getDefaultEndpoint());
533534
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
534535
builder.setSwitchToMtlsEndpointAllowed(true);
535536

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/EchoStubSettings.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.api.core.ApiFunction;
2424
import com.google.api.core.ApiFuture;
2525
import com.google.api.core.BetaApi;
26+
import com.google.api.core.ObsoleteApi;
2627
import com.google.api.gax.core.GaxProperties;
2728
import com.google.api.gax.core.GoogleCredentialsProvider;
2829
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -438,6 +439,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
438439
}
439440

440441
/** Returns the default service endpoint. */
442+
@ObsoleteApi(
443+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
441444
public static String getDefaultEndpoint() {
442445
return "localhost:7469";
443446
}
@@ -696,7 +699,6 @@ private static Builder createDefault() {
696699
builder.setTransportChannelProvider(defaultTransportChannelProvider());
697700
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
698701
builder.setInternalHeaderProvider(defaultApiClientHeaderProviderBuilder().build());
699-
builder.setEndpoint(getDefaultEndpoint());
700702
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
701703
builder.setSwitchToMtlsEndpointAllowed(true);
702704

@@ -709,7 +711,6 @@ private static Builder createHttpJsonDefault() {
709711
builder.setTransportChannelProvider(defaultHttpJsonTransportProviderBuilder().build());
710712
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
711713
builder.setInternalHeaderProvider(defaultHttpJsonApiClientHeaderProviderBuilder().build());
712-
builder.setEndpoint(getDefaultEndpoint());
713714
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
714715
builder.setSwitchToMtlsEndpointAllowed(true);
715716

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/IdentityStubSettings.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import com.google.api.core.ApiFunction;
2323
import com.google.api.core.ApiFuture;
2424
import com.google.api.core.BetaApi;
25+
import com.google.api.core.ObsoleteApi;
2526
import com.google.api.gax.core.GaxProperties;
2627
import com.google.api.gax.core.GoogleCredentialsProvider;
2728
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -309,6 +310,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
309310
}
310311

311312
/** Returns the default service endpoint. */
313+
@ObsoleteApi(
314+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
312315
public static String getDefaultEndpoint() {
313316
return "localhost:7469";
314317
}
@@ -524,7 +527,6 @@ private static Builder createDefault() {
524527
builder.setTransportChannelProvider(defaultTransportChannelProvider());
525528
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
526529
builder.setInternalHeaderProvider(defaultApiClientHeaderProviderBuilder().build());
527-
builder.setEndpoint(getDefaultEndpoint());
528530
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
529531
builder.setSwitchToMtlsEndpointAllowed(true);
530532

@@ -537,7 +539,6 @@ private static Builder createHttpJsonDefault() {
537539
builder.setTransportChannelProvider(defaultHttpJsonTransportProviderBuilder().build());
538540
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
539541
builder.setInternalHeaderProvider(defaultHttpJsonApiClientHeaderProviderBuilder().build());
540-
builder.setEndpoint(getDefaultEndpoint());
541542
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
542543
builder.setSwitchToMtlsEndpointAllowed(true);
543544

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/MessagingStubSettings.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.api.core.ApiFunction;
2424
import com.google.api.core.ApiFuture;
2525
import com.google.api.core.BetaApi;
26+
import com.google.api.core.ObsoleteApi;
2627
import com.google.api.gax.core.GaxProperties;
2728
import com.google.api.gax.core.GoogleCredentialsProvider;
2829
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -451,6 +452,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
451452
}
452453

453454
/** Returns the default service endpoint. */
455+
@ObsoleteApi(
456+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
454457
public static String getDefaultEndpoint() {
455458
return "localhost:7469";
456459
}
@@ -732,7 +735,6 @@ private static Builder createDefault() {
732735
builder.setTransportChannelProvider(defaultTransportChannelProvider());
733736
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
734737
builder.setInternalHeaderProvider(defaultApiClientHeaderProviderBuilder().build());
735-
builder.setEndpoint(getDefaultEndpoint());
736738
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
737739
builder.setSwitchToMtlsEndpointAllowed(true);
738740

@@ -745,7 +747,6 @@ private static Builder createHttpJsonDefault() {
745747
builder.setTransportChannelProvider(defaultHttpJsonTransportProviderBuilder().build());
746748
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
747749
builder.setInternalHeaderProvider(defaultHttpJsonApiClientHeaderProviderBuilder().build());
748-
builder.setEndpoint(getDefaultEndpoint());
749750
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
750751
builder.setSwitchToMtlsEndpointAllowed(true);
751752

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/SequenceServiceStubSettings.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.api.core.ApiFunction;
2222
import com.google.api.core.ApiFuture;
2323
import com.google.api.core.BetaApi;
24+
import com.google.api.core.ObsoleteApi;
2425
import com.google.api.gax.core.GaxProperties;
2526
import com.google.api.gax.core.GoogleCredentialsProvider;
2627
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -274,6 +275,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
274275
}
275276

276277
/** Returns the default service endpoint. */
278+
@ObsoleteApi(
279+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
277280
public static String getDefaultEndpoint() {
278281
return "localhost:7469";
279282
}
@@ -507,7 +510,6 @@ private static Builder createDefault() {
507510
builder.setTransportChannelProvider(defaultTransportChannelProvider());
508511
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
509512
builder.setInternalHeaderProvider(defaultApiClientHeaderProviderBuilder().build());
510-
builder.setEndpoint(getDefaultEndpoint());
511513
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
512514
builder.setSwitchToMtlsEndpointAllowed(true);
513515

@@ -520,7 +522,6 @@ private static Builder createHttpJsonDefault() {
520522
builder.setTransportChannelProvider(defaultHttpJsonTransportProviderBuilder().build());
521523
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
522524
builder.setInternalHeaderProvider(defaultHttpJsonApiClientHeaderProviderBuilder().build());
523-
builder.setEndpoint(getDefaultEndpoint());
524525
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
525526
builder.setSwitchToMtlsEndpointAllowed(true);
526527

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/TestingStubSettings.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.api.core.ApiFunction;
2424
import com.google.api.core.ApiFuture;
2525
import com.google.api.core.BetaApi;
26+
import com.google.api.core.ObsoleteApi;
2627
import com.google.api.gax.core.GaxProperties;
2728
import com.google.api.gax.core.GoogleCredentialsProvider;
2829
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -391,6 +392,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
391392
}
392393

393394
/** Returns the default service endpoint. */
395+
@ObsoleteApi(
396+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
394397
public static String getDefaultEndpoint() {
395398
return "localhost:7469";
396399
}
@@ -612,7 +615,6 @@ private static Builder createDefault() {
612615
builder.setTransportChannelProvider(defaultTransportChannelProvider());
613616
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
614617
builder.setInternalHeaderProvider(defaultApiClientHeaderProviderBuilder().build());
615-
builder.setEndpoint(getDefaultEndpoint());
616618
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
617619
builder.setSwitchToMtlsEndpointAllowed(true);
618620

@@ -625,7 +627,6 @@ private static Builder createHttpJsonDefault() {
625627
builder.setTransportChannelProvider(defaultHttpJsonTransportProviderBuilder().build());
626628
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
627629
builder.setInternalHeaderProvider(defaultHttpJsonApiClientHeaderProviderBuilder().build());
628-
builder.setEndpoint(getDefaultEndpoint());
629630
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
630631
builder.setSwitchToMtlsEndpointAllowed(true);
631632

‎test/integration/goldens/apigeeconnect/src/com/google/cloud/apigeeconnect/v1/stub/ConnectionServiceStubSettings.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.api.core.ApiFunction;
2222
import com.google.api.core.ApiFuture;
2323
import com.google.api.core.BetaApi;
24+
import com.google.api.core.ObsoleteApi;
2425
import com.google.api.gax.core.GaxProperties;
2526
import com.google.api.gax.core.GoogleCredentialsProvider;
2627
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -194,6 +195,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
194195
}
195196

196197
/** Returns the default service endpoint. */
198+
@ObsoleteApi(
199+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
197200
public static String getDefaultEndpoint() {
198201
return "apigeeconnect.googleapis.com:443";
199202
}
@@ -349,7 +352,6 @@ private static Builder createDefault() {
349352
builder.setTransportChannelProvider(defaultTransportChannelProvider());
350353
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
351354
builder.setInternalHeaderProvider(defaultApiClientHeaderProviderBuilder().build());
352-
builder.setEndpoint(getDefaultEndpoint());
353355
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
354356
builder.setSwitchToMtlsEndpointAllowed(true);
355357

@@ -362,7 +364,6 @@ private static Builder createHttpJsonDefault() {
362364
builder.setTransportChannelProvider(defaultHttpJsonTransportProviderBuilder().build());
363365
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
364366
builder.setInternalHeaderProvider(defaultHttpJsonApiClientHeaderProviderBuilder().build());
365-
builder.setEndpoint(getDefaultEndpoint());
366367
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
367368
builder.setSwitchToMtlsEndpointAllowed(true);
368369

‎test/integration/goldens/apigeeconnect/src/com/google/cloud/apigeeconnect/v1/stub/TetherStubSettings.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import com.google.api.core.ApiFunction;
2020
import com.google.api.core.BetaApi;
21+
import com.google.api.core.ObsoleteApi;
2122
import com.google.api.gax.core.GaxProperties;
2223
import com.google.api.gax.core.GoogleCredentialsProvider;
2324
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -114,6 +115,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
114115
}
115116

116117
/** Returns the default service endpoint. */
118+
@ObsoleteApi(
119+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
117120
public static String getDefaultEndpoint() {
118121
return "apigeeconnect.googleapis.com:443";
119122
}
@@ -229,7 +232,6 @@ private static Builder createDefault() {
229232
builder.setTransportChannelProvider(defaultTransportChannelProvider());
230233
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
231234
builder.setInternalHeaderProvider(defaultApiClientHeaderProviderBuilder().build());
232-
builder.setEndpoint(getDefaultEndpoint());
233235
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
234236
builder.setSwitchToMtlsEndpointAllowed(true);
235237

‎test/integration/goldens/asset/src/com/google/cloud/asset/v1/stub/AssetServiceStubSettings.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.google.api.core.ApiFunction;
2525
import com.google.api.core.ApiFuture;
2626
import com.google.api.core.BetaApi;
27+
import com.google.api.core.ObsoleteApi;
2728
import com.google.api.gax.core.GaxProperties;
2829
import com.google.api.gax.core.GoogleCredentialsProvider;
2930
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -583,6 +584,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
583584
}
584585

585586
/** Returns the default service endpoint. */
587+
@ObsoleteApi(
588+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
586589
public static String getDefaultEndpoint() {
587590
return "cloudasset.googleapis.com:443";
588591
}
@@ -963,7 +966,6 @@ private static Builder createDefault() {
963966
builder.setTransportChannelProvider(defaultTransportChannelProvider());
964967
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
965968
builder.setInternalHeaderProvider(defaultApiClientHeaderProviderBuilder().build());
966-
builder.setEndpoint(getDefaultEndpoint());
967969
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
968970
builder.setSwitchToMtlsEndpointAllowed(true);
969971

@@ -976,7 +978,6 @@ private static Builder createHttpJsonDefault() {
976978
builder.setTransportChannelProvider(defaultHttpJsonTransportProviderBuilder().build());
977979
builder.setCredentialsProvider(defaultCredentialsProviderBuilder().build());
978980
builder.setInternalHeaderProvider(defaultHttpJsonApiClientHeaderProviderBuilder().build());
979-
builder.setEndpoint(getDefaultEndpoint());
980981
builder.setMtlsEndpoint(getDefaultMtlsEndpoint());
981982
builder.setSwitchToMtlsEndpointAllowed(true);
982983

0 commit comments

Comments
 (0)