Skip to content

Commit 9ea0253

Browse files
lqiu96lqiu96
committed
feat: Mark getDefaultEndpoint() with @ObsoleteApi
1 parent 98b5bd7 commit 9ea0253

File tree

34 files changed

+108
-0
lines changed

34 files changed

+108
-0
lines changed

‎gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import com.google.api.core.ApiFunction;
1919
import com.google.api.core.ApiFuture;
2020
import com.google.api.core.BetaApi;
21+
import com.google.api.core.ObsoleteApi;
2122
import com.google.api.gax.batching.BatchingSettings;
2223
import com.google.api.gax.batching.FlowControlSettings;
2324
import com.google.api.gax.batching.FlowController.LimitExceededBehavior;
@@ -1190,6 +1191,13 @@ private List<MethodDefinition> createDefaultHelperAndGetterMethods(
11901191
.setReturnType(returnType)
11911192
.setName("getDefaultEndpoint")
11921193
.setReturnExpr(ValueExpr.withValue(StringObjectValue.withValue(service.defaultHost())))
1194+
.setAnnotations(
1195+
ImmutableList.of(
1196+
AnnotationNode.builder()
1197+
.setType(FIXED_TYPESTORE.get(ObsoleteApi.class.getSimpleName()))
1198+
.setDescription(
1199+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
1200+
.build()))
11931201
.build());
11941202

11951203
// Create the getDefaultMtlsEndpoint method.
@@ -2068,6 +2076,7 @@ private static TypeStore createStaticTypes() {
20682076
List.class,
20692077
Lists.class,
20702078
MonitoredResourceDescriptor.class,
2079+
ObsoleteApi.class,
20712080
Operation.class,
20722081
OperationCallSettings.class,
20732082
OperationSnapshot.class,

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/ApiVersionTestingStubSettings.golden

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.google.api.version.test.stub;
22

33
import com.google.api.core.ApiFunction;
4+
import com.google.api.core.ObsoleteApi;
45
import com.google.api.gax.core.GaxProperties;
56
import com.google.api.gax.core.GoogleCredentialsProvider;
67
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -91,6 +92,8 @@ public class EchoWithVersionStubSettings extends StubSettings<EchoWithVersionStu
9192
}
9293

9394
/** Returns the default service endpoint. */
95+
@ObsoleteApi(
96+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
9497
public static String getDefaultEndpoint() {
9598
return "localhost:7469";
9699
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/DeprecatedServiceStubSettings.golden

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.google.testdata.v1.stub;
22

33
import com.google.api.core.ApiFunction;
4+
import com.google.api.core.ObsoleteApi;
45
import com.google.api.gax.core.GaxProperties;
56
import com.google.api.gax.core.GoogleCredentialsProvider;
67
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -107,6 +108,8 @@ public class DeprecatedServiceStubSettings extends StubSettings<DeprecatedServic
107108
}
108109

109110
/** Returns the default service endpoint. */
111+
@ObsoleteApi(
112+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
110113
public static String getDefaultEndpoint() {
111114
return "localhost:7469";
112115
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/EchoStubSettings.golden

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import static com.google.showcase.v1beta1.EchoClient.SimplePagedExpandPagedRespo
66
import com.google.api.core.ApiFunction;
77
import com.google.api.core.ApiFuture;
88
import com.google.api.core.BetaApi;
9+
import com.google.api.core.ObsoleteApi;
910
import com.google.api.gax.core.GaxProperties;
1011
import com.google.api.gax.core.GoogleCredentialsProvider;
1112
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -291,6 +292,8 @@ public class EchoStubSettings extends StubSettings<EchoStubSettings> {
291292
}
292293

293294
/** Returns the default service endpoint. */
295+
@ObsoleteApi(
296+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
294297
public static String getDefaultEndpoint() {
295298
return "localhost:7469";
296299
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/LoggingServiceV2StubSettings.golden

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import static com.google.logging.v2.LoggingServiceV2Client.ListMonitoredResource
77
import com.google.api.MonitoredResourceDescriptor;
88
import com.google.api.core.ApiFunction;
99
import com.google.api.core.ApiFuture;
10+
import com.google.api.core.ObsoleteApi;
1011
import com.google.api.gax.batching.BatchingSettings;
1112
import com.google.api.gax.batching.FlowControlSettings;
1213
import com.google.api.gax.batching.FlowController;
@@ -433,6 +434,8 @@ public class LoggingServiceV2StubSettings extends StubSettings<LoggingServiceV2S
433434
}
434435

435436
/** Returns the default service endpoint. */
437+
@ObsoleteApi(
438+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
436439
public static String getDefaultEndpoint() {
437440
return "logging.googleapis.com:443";
438441
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/goldens/PublisherStubSettings.golden

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import static com.google.pubsub.v1.PublisherClient.ListTopicsPagedResponse;
66

77
import com.google.api.core.ApiFunction;
88
import com.google.api.core.ApiFuture;
9+
import com.google.api.core.ObsoleteApi;
910
import com.google.api.gax.batching.BatchingSettings;
1011
import com.google.api.gax.batching.FlowControlSettings;
1112
import com.google.api.gax.batching.FlowController;
@@ -442,6 +443,8 @@ public class PublisherStubSettings extends StubSettings<PublisherStubSettings> {
442443
}
443444

444445
/** Returns the default service endpoint. */
446+
@ObsoleteApi(
447+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
445448
public static String getDefaultEndpoint() {
446449
return "pubsub.googleapis.com:443";
447450
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpcrest/goldens/EchoStubSettings.golden

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import static com.google.showcase.grpcrest.v1beta1.EchoClient.SimplePagedExpandP
66
import com.google.api.core.ApiFunction;
77
import com.google.api.core.ApiFuture;
88
import com.google.api.core.BetaApi;
9+
import com.google.api.core.ObsoleteApi;
910
import com.google.api.gax.core.GaxProperties;
1011
import com.google.api.gax.core.GoogleCredentialsProvider;
1112
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -307,6 +308,8 @@ public class EchoStubSettings extends StubSettings<EchoStubSettings> {
307308
}
308309

309310
/** Returns the default service endpoint. */
311+
@ObsoleteApi(
312+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
310313
public static String getDefaultEndpoint() {
311314
return "localhost:7469";
312315
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpcrest/goldens/WickedStubSettings.golden

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package com.google.showcase.v1beta1.stub;
22

33
import com.google.api.core.ApiFunction;
44
import com.google.api.core.BetaApi;
5+
import com.google.api.core.ObsoleteApi;
56
import com.google.api.gax.core.GaxProperties;
67
import com.google.api.gax.core.GoogleCredentialsProvider;
78
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -105,6 +106,8 @@ public class WickedStubSettings extends StubSettings<WickedStubSettings> {
105106
}
106107

107108
/** Returns the default service endpoint. */
109+
@ObsoleteApi(
110+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
108111
public static String getDefaultEndpoint() {
109112
return "localhost:7469";
110113
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/rest/goldens/ComplianceStubSettings.golden

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package com.google.showcase.v1beta1.stub;
22

33
import com.google.api.core.ApiFunction;
44
import com.google.api.core.BetaApi;
5+
import com.google.api.core.ObsoleteApi;
56
import com.google.api.gax.core.GaxProperties;
67
import com.google.api.gax.core.GoogleCredentialsProvider;
78
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -137,6 +138,8 @@ public class ComplianceStubSettings extends StubSettings<ComplianceStubSettings>
137138
}
138139

139140
/** Returns the default service endpoint. */
141+
@ObsoleteApi(
142+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
140143
public static String getDefaultEndpoint() {
141144
return "localhost:7469";
142145
}

‎gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/rest/goldens/HttpJsonApiVersionTestingStubSettings.golden

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.google.api.version.test.stub;
22

33
import com.google.api.core.ApiFunction;
4+
import com.google.api.core.ObsoleteApi;
45
import com.google.api.gax.core.GaxProperties;
56
import com.google.api.gax.core.GoogleCredentialsProvider;
67
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -91,6 +92,8 @@ public class EchoWithVersionStubSettings extends StubSettings<EchoWithVersionStu
9192
}
9293

9394
/** Returns the default service endpoint. */
95+
@ObsoleteApi(
96+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
9497
public static String getDefaultEndpoint() {
9598
return "localhost:7469";
9699
}

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/ComplianceStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.api.core.ApiFunction;
2222
import com.google.api.core.ApiFuture;
2323
import com.google.api.core.BetaApi;
24+
import com.google.api.core.ObsoleteApi;
2425
import com.google.api.gax.core.GaxProperties;
2526
import com.google.api.gax.core.GoogleCredentialsProvider;
2627
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -279,6 +280,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
279280
}
280281

281282
/** Returns the default service endpoint. */
283+
@ObsoleteApi(
284+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
282285
public static String getDefaultEndpoint() {
283286
return "localhost:7469";
284287
}

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/EchoStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.api.core.ApiFunction;
2424
import com.google.api.core.ApiFuture;
2525
import com.google.api.core.BetaApi;
26+
import com.google.api.core.ObsoleteApi;
2627
import com.google.api.gax.core.GaxProperties;
2728
import com.google.api.gax.core.GoogleCredentialsProvider;
2829
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -438,6 +439,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
438439
}
439440

440441
/** Returns the default service endpoint. */
442+
@ObsoleteApi(
443+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
441444
public static String getDefaultEndpoint() {
442445
return "localhost:7469";
443446
}

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/IdentityStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import com.google.api.core.ApiFunction;
2323
import com.google.api.core.ApiFuture;
2424
import com.google.api.core.BetaApi;
25+
import com.google.api.core.ObsoleteApi;
2526
import com.google.api.gax.core.GaxProperties;
2627
import com.google.api.gax.core.GoogleCredentialsProvider;
2728
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -309,6 +310,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
309310
}
310311

311312
/** Returns the default service endpoint. */
313+
@ObsoleteApi(
314+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
312315
public static String getDefaultEndpoint() {
313316
return "localhost:7469";
314317
}

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/MessagingStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.api.core.ApiFunction;
2424
import com.google.api.core.ApiFuture;
2525
import com.google.api.core.BetaApi;
26+
import com.google.api.core.ObsoleteApi;
2627
import com.google.api.gax.core.GaxProperties;
2728
import com.google.api.gax.core.GoogleCredentialsProvider;
2829
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -451,6 +452,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
451452
}
452453

453454
/** Returns the default service endpoint. */
455+
@ObsoleteApi(
456+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
454457
public static String getDefaultEndpoint() {
455458
return "localhost:7469";
456459
}

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/SequenceServiceStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.api.core.ApiFunction;
2222
import com.google.api.core.ApiFuture;
2323
import com.google.api.core.BetaApi;
24+
import com.google.api.core.ObsoleteApi;
2425
import com.google.api.gax.core.GaxProperties;
2526
import com.google.api.gax.core.GoogleCredentialsProvider;
2627
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -274,6 +275,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
274275
}
275276

276277
/** Returns the default service endpoint. */
278+
@ObsoleteApi(
279+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
277280
public static String getDefaultEndpoint() {
278281
return "localhost:7469";
279282
}

‎showcase/gapic-showcase/src/main/java/com/google/showcase/v1beta1/stub/TestingStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.api.core.ApiFunction;
2424
import com.google.api.core.ApiFuture;
2525
import com.google.api.core.BetaApi;
26+
import com.google.api.core.ObsoleteApi;
2627
import com.google.api.gax.core.GaxProperties;
2728
import com.google.api.gax.core.GoogleCredentialsProvider;
2829
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -391,6 +392,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
391392
}
392393

393394
/** Returns the default service endpoint. */
395+
@ObsoleteApi(
396+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
394397
public static String getDefaultEndpoint() {
395398
return "localhost:7469";
396399
}

‎test/integration/goldens/apigeeconnect/src/com/google/cloud/apigeeconnect/v1/stub/ConnectionServiceStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.api.core.ApiFunction;
2222
import com.google.api.core.ApiFuture;
2323
import com.google.api.core.BetaApi;
24+
import com.google.api.core.ObsoleteApi;
2425
import com.google.api.gax.core.GaxProperties;
2526
import com.google.api.gax.core.GoogleCredentialsProvider;
2627
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -194,6 +195,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
194195
}
195196

196197
/** Returns the default service endpoint. */
198+
@ObsoleteApi(
199+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
197200
public static String getDefaultEndpoint() {
198201
return "apigeeconnect.googleapis.com:443";
199202
}

‎test/integration/goldens/apigeeconnect/src/com/google/cloud/apigeeconnect/v1/stub/TetherStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package com.google.cloud.apigeeconnect.v1.stub;
1818

1919
import com.google.api.core.ApiFunction;
20+
import com.google.api.core.ObsoleteApi;
2021
import com.google.api.gax.core.GaxProperties;
2122
import com.google.api.gax.core.GoogleCredentialsProvider;
2223
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -113,6 +114,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
113114
}
114115

115116
/** Returns the default service endpoint. */
117+
@ObsoleteApi(
118+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
116119
public static String getDefaultEndpoint() {
117120
return "apigeeconnect.googleapis.com:443";
118121
}

‎test/integration/goldens/asset/src/com/google/cloud/asset/v1/stub/AssetServiceStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.google.api.core.ApiFunction;
2525
import com.google.api.core.ApiFuture;
2626
import com.google.api.core.BetaApi;
27+
import com.google.api.core.ObsoleteApi;
2728
import com.google.api.gax.core.GaxProperties;
2829
import com.google.api.gax.core.GoogleCredentialsProvider;
2930
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -583,6 +584,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
583584
}
584585

585586
/** Returns the default service endpoint. */
587+
@ObsoleteApi(
588+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
586589
public static String getDefaultEndpoint() {
587590
return "cloudasset.googleapis.com:443";
588591
}

‎test/integration/goldens/bigtable/src/com/google/cloud/bigtable/data/v2/stub/BigtableStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package com.google.cloud.bigtable.data.v2.stub;
1818

1919
import com.google.api.core.ApiFunction;
20+
import com.google.api.core.ObsoleteApi;
2021
import com.google.api.gax.core.GaxProperties;
2122
import com.google.api.gax.core.GoogleCredentialsProvider;
2223
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -177,6 +178,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
177178
}
178179

179180
/** Returns the default service endpoint. */
181+
@ObsoleteApi(
182+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
180183
public static String getDefaultEndpoint() {
181184
return "bigtable.googleapis.com:443";
182185
}

‎test/integration/goldens/compute/src/com/google/cloud/compute/v1small/stub/AddressesStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import com.google.api.core.ApiFunction;
2323
import com.google.api.core.ApiFuture;
24+
import com.google.api.core.ObsoleteApi;
2425
import com.google.api.gax.core.GaxProperties;
2526
import com.google.api.gax.core.GoogleCredentialsProvider;
2627
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -300,6 +301,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
300301
}
301302

302303
/** Returns the default service endpoint. */
304+
@ObsoleteApi(
305+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
303306
public static String getDefaultEndpoint() {
304307
return "compute.googleapis.com:443";
305308
}

‎test/integration/goldens/compute/src/com/google/cloud/compute/v1small/stub/RegionOperationsStubSettings.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package com.google.cloud.compute.v1small.stub;
1818

1919
import com.google.api.core.ApiFunction;
20+
import com.google.api.core.ObsoleteApi;
2021
import com.google.api.gax.core.GaxProperties;
2122
import com.google.api.gax.core.GoogleCredentialsProvider;
2223
import com.google.api.gax.core.InstantiatingExecutorProvider;
@@ -125,6 +126,8 @@ public static InstantiatingExecutorProvider.Builder defaultExecutorProviderBuild
125126
}
126127

127128
/** Returns the default service endpoint. */
129+
@ObsoleteApi(
130+
"See https://github.com/googleapis/sdk-platform-java/issues/2346 for more information")
128131
public static String getDefaultEndpoint() {
129132
return "compute.googleapis.com:443";
130133
}

0 commit comments

Comments
 (0)