Skip to content

Commit 9ec3531

Browse files
committed
continue: rename apiVersion used in sample regiontags to apiMajorVersion.
1 parent 8772c51 commit 9ec3531

10 files changed

+15
-15
lines changed

gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/Composer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ static List<GapicClass> prepareExecutableSamples(List<GapicClass> clazzes) {
207207
sample ->
208208
samples.add(
209209
addRegionTagAndHeaderToSample(
210-
sample, gapicClass.apiShortName(), gapicClass.apiVersion())));
210+
sample, gapicClass.apiShortName(), gapicClass.apiMajorVersion())));
211211
clazzesWithSamples.add(gapicClass.withSamples(samples));
212212
});
213213
return clazzesWithSamples;

gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/common/AbstractServiceClientClassComposer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ public GapicClass generate(GapicContext context, Service service) {
173173
updateGapicMetadata(context, service, className, grpcRpcsToJavaMethodNames);
174174
return GapicClass.create(kind, classDef, SampleComposerUtil.handleDuplicateSamples(samples))
175175
.withApiShortName(service.apiShortName())
176-
.withApiVersion(service.apiMajorVersion());
176+
.withApiMajorVersion(service.apiMajorVersion());
177177
}
178178

179179
private static List<AnnotationNode> createClassAnnotations(Service service, TypeStore typeStore) {

gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/common/AbstractServiceSettingsClassComposer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public GapicClass generate(GapicContext context, Service service) {
128128
.build();
129129
return GapicClass.create(kind, classDef, SampleComposerUtil.handleDuplicateSamples(samples))
130130
.withApiShortName(service.apiShortName())
131-
.withApiVersion(service.apiMajorVersion());
131+
.withApiMajorVersion(service.apiMajorVersion());
132132
}
133133

134134
private static List<CommentStatement> createClassHeaderComments(

gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ public GapicClass generate(GapicContext context, Service service) {
204204
return GapicClass.create(
205205
GapicClass.Kind.STUB, classDef, SampleComposerUtil.handleDuplicateSamples(samples))
206206
.withApiShortName(service.apiShortName())
207-
.withApiVersion(service.apiMajorVersion());
207+
.withApiMajorVersion(service.apiMajorVersion());
208208
}
209209

210210
protected MethodDefinition createDefaultCredentialsProviderBuilderMethod() {

gapic-generator-java/src/main/java/com/google/api/generator/gapic/model/GapicClass.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public enum Kind {
4343
public abstract String apiShortName();
4444

4545
// Only used for generating the region tag for samples; therefore only used in select Composers.
46-
public abstract String apiVersion();
46+
public abstract String apiMajorVersion();
4747

4848
/**
4949
* Create a GapicClass with minimal information. This is intended to be used for GapicClasses that
@@ -76,7 +76,7 @@ static Builder builder() {
7676
return new AutoValue_GapicClass.Builder()
7777
.setSamples(Collections.emptyList())
7878
.setApiShortName("")
79-
.setApiVersion("");
79+
.setApiMajorVersion("");
8080
}
8181

8282
abstract Builder toBuilder();
@@ -89,8 +89,8 @@ public final GapicClass withApiShortName(String apiShortName) {
8989
return toBuilder().setApiShortName(apiShortName).build();
9090
}
9191

92-
public final GapicClass withApiVersion(String apiVersion) {
93-
return toBuilder().setApiVersion(apiVersion).build();
92+
public final GapicClass withApiMajorVersion(String apiMajorVersion) {
93+
return toBuilder().setApiMajorVersion(apiMajorVersion).build();
9494
}
9595

9696
@AutoValue.Builder
@@ -103,7 +103,7 @@ abstract static class Builder {
103103

104104
abstract Builder setApiShortName(String apiShortName);
105105

106-
abstract Builder setApiVersion(String apiVersion);
106+
abstract Builder setApiMajorVersion(String apiMajorVersion);
107107

108108
abstract GapicClass build();
109109
}

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/ComposerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public class ComposerTest {
4545
GrpcServiceCallableFactoryClassComposer.instance()
4646
.generate(context, echoProtoService)
4747
.withApiShortName(echoProtoService.apiShortName())
48-
.withApiVersion(echoProtoService.apiMajorVersion()));
48+
.withApiMajorVersion(echoProtoService.apiMajorVersion()));
4949
private final Sample sample =
5050
Sample.builder()
5151
.setRegionTag(
@@ -160,7 +160,7 @@ private List<GapicClass> getTestClassListFromService(Service testService) {
160160
.generate(context, testService)
161161
.withSamples(ListofSamples)
162162
.withApiShortName(testService.apiShortName())
163-
.withApiVersion(testService.apiMajorVersion());
163+
.withApiMajorVersion(testService.apiMajorVersion());
164164
List<GapicClass> testClassList = Arrays.asList(new GapicClass[] {testClass});
165165
return testClassList;
166166
}

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/ServiceClientClassComposerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,6 @@ public void generateServiceClientClasses() {
8383
Assert.assertGoldenSamples(
8484
this.getClass(), name, clazz.classDefinition().packageString(), clazz.samples());
8585
Assert.assertCodeEquals(clazz.apiShortName(), apiShortNameExpected);
86-
Assert.assertCodeEquals(clazz.apiVersion(), apiVersionExpected);
86+
Assert.assertCodeEquals(clazz.apiMajorVersion(), apiVersionExpected);
8787
}
8888
}

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/ServiceSettingsClassComposerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,6 @@ public void generateServiceSettingsClasses() {
6969
clazz.classDefinition().packageString(),
7070
clazz.samples());
7171
Assert.assertCodeEquals(clazz.apiShortName(), apiShortNameExpected);
72-
Assert.assertCodeEquals(clazz.apiVersion(), apiVersionExpected);
72+
Assert.assertCodeEquals(clazz.apiMajorVersion(), apiVersionExpected);
7373
}
7474
}

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/ServiceStubClassComposerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@ public void generateServiceStubClasses() {
5555
Assert.assertGoldenClass(this.getClass(), clazz, name + ".golden");
5656
Assert.assertEmptySamples(clazz.samples());
5757
Assert.assertCodeEquals(clazz.apiShortName(), apiShortNameExpected);
58-
Assert.assertCodeEquals(clazz.apiVersion(), apiVersionExpected);
58+
Assert.assertCodeEquals(clazz.apiMajorVersion(), apiVersionExpected);
5959
}
6060
}

gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/grpc/ServiceStubSettingsClassComposerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,6 @@ public void generateServiceStubSettingsClasses() {
8181
clazz.classDefinition().packageString(),
8282
clazz.samples());
8383
Assert.assertCodeEquals(clazz.apiShortName(), apiShortNameExpected);
84-
Assert.assertCodeEquals(clazz.apiVersion(), apiVersionExpected);
84+
Assert.assertCodeEquals(clazz.apiMajorVersion(), apiVersionExpected);
8585
}
8686
}

0 commit comments

Comments
 (0)