Skip to content

Commit f74b29f

Browse files
JoeWang1127lqiu96
authored andcommitted
chore: add library params (#2457)
In this PR: - Add parameters to `LibraryConfig' - `codeowner_team`, found in java-analytics-admin - `excluded_poms`, found in java-iam, java-compute - `excluded_dependencies` found in java-iam, java-compute
1 parent 09aa864 commit f74b29f

File tree

5 files changed

+24
-0
lines changed

5 files changed

+24
-0
lines changed

library_generation/model/generation_config.py

+3
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,9 @@ def from_yaml(path_to_yaml: str) -> GenerationConfig:
7979
release_level=__optional(library, "release_level", "preview"),
8080
api_id=__optional(library, "api_id", None),
8181
api_reference=__optional(library, "api_reference", None),
82+
codeowner_team=__optional(library, "codeowner_team", None),
83+
excluded_poms=__optional(library, "excluded_poms", None),
84+
excluded_dependencies=__optional(library, "excluded_dependencies", None),
8285
client_documentation=__optional(library, "client_documentation", None),
8386
distribution_name=__optional(library, "distribution_name", None),
8487
googleapis_commitish=__optional(library, "googleapis_commitish", None),

library_generation/model/library_config.py

+6
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,11 @@ def __init__(
3333
release_level: Optional[str] = None,
3434
api_id: Optional[str] = None,
3535
api_reference: Optional[str] = None,
36+
codeowner_team: Optional[str] = None,
3637
client_documentation: Optional[str] = None,
3738
distribution_name: Optional[str] = None,
39+
excluded_dependencies: Optional[str] = None,
40+
excluded_poms: Optional[str] = None,
3841
googleapis_commitish: Optional[str] = None,
3942
group_id: Optional[str] = "com.google.cloud",
4043
issue_tracker: Optional[str] = None,
@@ -53,6 +56,9 @@ def __init__(
5356
self.release_level = release_level if release_level else "preview"
5457
self.api_id = api_id
5558
self.api_reference = api_reference
59+
self.codeowner_team = codeowner_team
60+
self.excluded_dependencies = excluded_dependencies
61+
self.excluded_poms = excluded_poms
5662
self.client_documentation = client_documentation
5763
self.distribution_name = distribution_name
5864
self.googleapis_commitish = googleapis_commitish

library_generation/test/resources/test-config/generation_config.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ libraries:
2626
release_level: "stable"
2727
issue_tracker: "https://issuetracker.google.com/issues/new?component=187210&template=0"
2828
api_reference: "https://cloud.google.com/resource-manager/docs/cloud-asset-inventory/overview"
29+
codeowner_team: "@googleapis/analytics-dpe"
30+
excluded_poms: proto-google-iam-v1-bom,google-iam-policy,proto-google-iam-v1
31+
excluded_dependencies: google-iam-policy
2932
GAPICs:
3033
- proto_path: google/cloud/asset/v1
3134
- proto_path: google/cloud/asset/v1p1beta1

library_generation/test/unit_tests.py

+6
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,12 @@ def test_from_yaml_succeeds(self):
192192
library.api_description,
193193
)
194194
self.assertEqual("asset", library.library_name)
195+
self.assertEqual("@googleapis/analytics-dpe", library.codeowner_team)
196+
self.assertEqual(
197+
"proto-google-iam-v1-bom,google-iam-policy,proto-google-iam-v1",
198+
library.excluded_poms,
199+
)
200+
self.assertEqual("google-iam-policy", library.excluded_dependencies)
195201
gapics = library.gapic_configs
196202
self.assertEqual(5, len(gapics))
197203
self.assertEqual("google/cloud/asset/v1", gapics[0].proto_path)

library_generation/utilities.py

+6
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,12 @@ def generate_prerequisite_files(
390390

391391
if library.api_reference:
392392
repo_metadata["api_reference"] = library.api_reference
393+
if library.codeowner_team:
394+
repo_metadata["codeowner_team"] = library.codeowner_team
395+
if library.excluded_dependencies:
396+
repo_metadata["excluded_dependencies"] = library.excluded_dependencies
397+
if library.excluded_poms:
398+
repo_metadata["excluded_poms"] = library.excluded_poms
393399
if library.issue_tracker:
394400
repo_metadata["issue_tracker"] = library.issue_tracker
395401
if library.rest_documentation:

0 commit comments

Comments
 (0)