Merge pull request #51 from foopang/fix/constants

Use constants for action types

Author: EricSimons

src/components/App.js

@@ -2,6 +2,7 @@ import agent from '../agent';
 import Header from './Header';
 import React from 'react';
 import { connect } from 'react-redux';
+import { APP_LOAD, REDIRECT } from '../constants/actionTypes';
 
 const mapStateToProps = state => ({
   appLoaded: state.common.appLoaded,
@@ -12,9 +13,9 @@ const mapStateToProps = state => ({
 
 const mapDispatchToProps = dispatch => ({
   onLoad: (payload, token) =>
-    dispatch({ type: 'APP_LOAD', payload, token, skipTracking: true }),
+    dispatch({ type: APP_LOAD, payload, token, skipTracking: true }),
   onRedirect: () =>
-    dispatch({ type: 'REDIRECT' })
+    dispatch({ type: REDIRECT })
 });
 
 class App extends React.Component {

src/components/Article/ArticleActions.js

@@ -2,10 +2,11 @@ import { Link } from 'react-router';
 import React from 'react';
 import agent from '../../agent';
 import { connect } from 'react-redux';
+import { DELETE_ARTICLE } from '../../constants/actionTypes';
 
 const mapDispatchToProps = dispatch => ({
   onClickDelete: payload =>
-    dispatch({ type: 'DELETE_ARTICLE', payload })
+    dispatch({ type: DELETE_ARTICLE, payload })
 });
 
 const ArticleActions = props => {

src/components/Article/CommentInput.js

@@ -1,10 +1,11 @@
 import React from 'react';
 import agent from '../../agent';
 import { connect } from 'react-redux';
+import { ADD_COMMENT } from '../../constants/actionTypes';
 
 const mapDispatchToProps = dispatch => ({
   onSubmit: payload =>
-    dispatch({ type: 'ADD_COMMENT', payload })
+    dispatch({ type: ADD_COMMENT, payload })
 });
 
 class CommentInput extends React.Component {

src/components/Article/DeleteButton.js

@@ -1,10 +1,11 @@
 import React from 'react';
 import agent from '../../agent';
 import { connect } from 'react-redux';
+import { DELETE_COMMENT } from '../../constants/actionTypes';
 
 const mapDispatchToProps = dispatch => ({
   onClick: (payload, commentId) =>
-    dispatch({ type: 'DELETE_COMMENT', payload, commentId })
+    dispatch({ type: DELETE_COMMENT, payload, commentId })
 });
 
 const DeleteButton = props => {

src/components/Article/index.js

@@ -7,6 +7,7 @@ import React from 'react';
 import agent from '../../agent';
 import { connect } from 'react-redux';
 import marked from 'marked';
+import { ARTICLE_PAGE_LOADED, ARTICLE_PAGE_UNLOADED } from '../../constants/actionTypes';
 
 const mapStateToProps = state => ({
   ...state.article,
@@ -15,9 +16,9 @@ const mapStateToProps = state => ({
 
 const mapDispatchToProps = dispatch => ({
   onLoad: payload =>
-    dispatch({ type: 'ARTICLE_PAGE_LOADED', payload }),
+    dispatch({ type: ARTICLE_PAGE_LOADED, payload }),
   onUnload: () =>
-    dispatch({ type: 'ARTICLE_PAGE_UNLOADED' })
+    dispatch({ type: ARTICLE_PAGE_UNLOADED })
 });
 
 class Article extends React.Component {

src/components/ArticlePreview.js

@@ -4,17 +4,18 @@ import React from 'react';
 import { Link } from 'react-router';
 import agent from '../agent';
 import { connect } from 'react-redux';
+import { ARTICLE_FAVORITED, ARTICLE_UNFAVORITED } from '../constants/actionTypes';
 
 const FAVORITED_CLASS = 'btn btn-sm btn-primary';
 const NOT_FAVORITED_CLASS = 'btn btn-sm btn-outline-primary';
 
 const mapDispatchToProps = dispatch => ({
   favorite: slug => dispatch({
-    type: 'ARTICLE_FAVORITED',
+    type: ARTICLE_FAVORITED,
     payload: agent.Articles.favorite(slug)
   }),
   unfavorite: slug => dispatch({
-    type: 'ARTICLE_UNFAVORITED',
+    type: ARTICLE_UNFAVORITED,
     payload: agent.Articles.unfavorite(slug)
   })
 });

src/components/Editor.js

@@ -4,24 +4,32 @@ import ListErrors from './ListErrors';
 import React from 'react';
 import agent from '../agent';
 import { connect } from 'react-redux';
+import {
+  ADD_TAG,
+  EDITOR_PAGE_LOADED,
+  REMOVE_TAG,
+  ARTICLE_SUBMITTED,
+  EDITOR_PAGE_UNLOADED,
+  UPDATE_FIELD_EDITOR
+} from '../constants/actionTypes';
 
 const mapStateToProps = state => ({
   ...state.editor
 });
 
 const mapDispatchToProps = dispatch => ({
   onAddTag: () =>
-    dispatch({ type: 'ADD_TAG' }),
+    dispatch({ type: ADD_TAG }),
   onLoad: payload =>
-    dispatch({ type: 'EDITOR_PAGE_LOADED', payload }),
+    dispatch({ type: EDITOR_PAGE_LOADED, payload }),
   onRemoveTag: tag =>
-    dispatch({ type: 'REMOVE_TAG', tag }),
+    dispatch({ type: REMOVE_TAG, tag }),
   onSubmit: payload =>
-    dispatch({ type: 'ARTICLE_SUBMITTED', payload }),
+    dispatch({ type: ARTICLE_SUBMITTED, payload }),
   onUnload: payload =>
-    dispatch({ type: 'EDITOR_PAGE_UNLOADED' }),
+    dispatch({ type: EDITOR_PAGE_UNLOADED }),
   onUpdateField: (key, value) =>
-    dispatch({ type: 'UPDATE_FIELD_EDITOR', key, value })
+    dispatch({ type: UPDATE_FIELD_EDITOR, key, value })
 });
 
 class Editor extends React.Component {

src/components/Home/MainView.js

@@ -2,6 +2,7 @@ import ArticleList from '../ArticleList';
 import React from 'react';
 import agent from '../../agent';
 import { connect } from 'react-redux';
+import { CHANGE_TAB } from '../../constants/actionTypes';
 
 const YourFeedTab = props => {
   if (props.token) {

src/components/Home/index.js

@@ -4,6 +4,11 @@ import React from 'react';
 import Tags from './Tags';
 import agent from '../../agent';
 import { connect } from 'react-redux';
+import {
+  HOME_PAGE_LOADED,
+  HOME_PAGE_UNLOADED,
+  APPLY_TAG_FILTER
+} from '../../constants/actionTypes';
 
 const Promise = global.Promise;
 
@@ -19,7 +24,7 @@ const mapDispatchToProps = dispatch => ({
   onLoad: (tab, pager, payload) =>
     dispatch({ type: 'HOME_PAGE_LOADED', tab, pager, payload }),
   onUnload: () =>
-    dispatch({  type: 'HOME_PAGE_UNLOADED' })
+    dispatch({  type: HOME_PAGE_UNLOADED })
 });
 
 class Home extends React.Component {

src/components/ListPagination.js

@@ -1,10 +1,11 @@
 import React from 'react';
 import agent from '../agent';
 import { connect } from 'react-redux';
+import { SET_PAGE } from '../constants/actionTypes';
 
 const mapDispatchToProps = dispatch => ({
   onSetPage: (page, payload) =>
-    dispatch({ type: 'SET_PAGE', page, payload })
+    dispatch({ type: SET_PAGE, page, payload })
 });
 
 const ListPagination = props => {

src/components/Login.js

@@ -3,18 +3,23 @@ import ListErrors from './ListErrors';
 import React from 'react';
 import agent from '../agent';
 import { connect } from 'react-redux';
+import {
+  UPDATE_FIELD_AUTH,
+  LOGIN,
+  LOGIN_PAGE_UNLOADED
+} from '../constants/actionTypes';
 
 const mapStateToProps = state => ({ ...state.auth });
 
 const mapDispatchToProps = dispatch => ({
   onChangeEmail: value =>
-    dispatch({ type: 'UPDATE_FIELD_AUTH', key: 'email', value }),
+    dispatch({ type: UPDATE_FIELD_AUTH, key: 'email', value }),
   onChangePassword: value =>
-    dispatch({ type: 'UPDATE_FIELD_AUTH', key: 'password', value }),
+    dispatch({ type: UPDATE_FIELD_AUTH, key: 'password', value }),
   onSubmit: (email, password) =>
-    dispatch({ type: 'LOGIN', payload: agent.Auth.login(email, password) }),
+    dispatch({ type: LOGIN, payload: agent.Auth.login(email, password) }),
   onUnload: () =>
-    dispatch({ type: 'LOGIN_PAGE_UNLOADED' })
+    dispatch({ type: LOGIN_PAGE_UNLOADED })
 });
 
 class Login extends React.Component {

src/components/Profile.js

@@ -5,6 +5,12 @@ import React from 'react';
 import { Link } from 'react-router';
 import agent from '../agent';
 import { connect } from 'react-redux';
+import {
+  FOLLOW_USER,
+  UNFOLLOW_USER,
+  PROFILE_PAGE_LOADED,
+  PROFILE_PAGE_UNLOADED
+} from '../constants/actionTypes';
 
 const EditProfileSettings = props => {
   if (props.isUser) {
@@ -59,15 +65,15 @@ const mapStateToProps = state => ({
 
 const mapDispatchToProps = dispatch => ({
   onFollow: username => dispatch({
-    type: 'FOLLOW_USER',
+    type: FOLLOW_USER,
     payload: agent.Profile.follow(username)
   }),
-  onLoad: payload => dispatch({ type: 'PROFILE_PAGE_LOADED', payload }),
+  onLoad: payload => dispatch({ type: PROFILE_PAGE_LOADED, payload }),
   onUnfollow: username => dispatch({
-    type: 'UNFOLLOW_USER',
+    type: UNFOLLOW_USER,
     payload: agent.Profile.unfollow(username)
   }),
-  onUnload: () => dispatch({ type: 'PROFILE_PAGE_UNLOADED' })
+  onUnload: () => dispatch({ type: PROFILE_PAGE_UNLOADED })
 });
 
 class Profile extends React.Component {

src/components/ProfileFavorites.js

@@ -5,12 +5,16 @@ import React from 'react';
 import { Link } from 'react-router';
 import agent from '../agent';
 import { connect } from 'react-redux';
+import {
+  PROFILE_FAVORITES_PAGE_LOADED,
+  PROFILE_FAVORITES_PAGE_UNLOADED
+} from '../constants/actionTypes';
 
 const mapDispatchToProps = dispatch => ({
   onLoad: (pager, payload) =>
     dispatch({ type: 'PROFILE_FAVORITES_PAGE_LOADED', pager, payload }),
   onUnload: () =>
-    dispatch({ type: 'PROFILE_FAVORITES_PAGE_UNLOADED' })
+    dispatch({ type: PROFILE_FAVORITES_PAGE_UNLOADED })
 });
 
 class ProfileFavorites extends Profile {

src/components/Register.js

@@ -3,22 +3,27 @@ import ListErrors from './ListErrors';
 import React from 'react';
 import agent from '../agent';
 import { connect } from 'react-redux';
+import {
+  UPDATE_FIELD_AUTH,
+  REGISTER,
+  REGISTER_PAGE_UNLOADED
+} from '../constants/actionTypes';
 
 const mapStateToProps = state => ({ ...state.auth });
 
 const mapDispatchToProps = dispatch => ({
   onChangeEmail: value =>
-    dispatch({ type: 'UPDATE_FIELD_AUTH', key: 'email', value }),
+    dispatch({ type: UPDATE_FIELD_AUTH, key: 'email', value }),
   onChangePassword: value =>
-    dispatch({ type: 'UPDATE_FIELD_AUTH', key: 'password', value }),
+    dispatch({ type: UPDATE_FIELD_AUTH, key: 'password', value }),
   onChangeUsername: value =>
-    dispatch({ type: 'UPDATE_FIELD_AUTH', key: 'username', value }),
+    dispatch({ type: UPDATE_FIELD_AUTH, key: 'username', value }),
   onSubmit: (username, email, password) => {
     const payload = agent.Auth.register(username, email, password);
-    dispatch({ type: 'REGISTER', payload })
+    dispatch({ type: REGISTER, payload })
   },
   onUnload: () =>
-    dispatch({ type: 'REGISTER_PAGE_UNLOADED' })
+    dispatch({ type: REGISTER_PAGE_UNLOADED })
 });
 
 class Register extends React.Component {

src/components/Settings.js

@@ -4,6 +4,11 @@ import { Link } from 'react-router';
 import agent from '../agent';
 import { connect } from 'react-redux';
 import store from '../store';
+import {
+  SETTINGS_SAVED,
+  SETTINGS_PAGE_UNLOADED,
+  LOGOUT
+} from '../constants/actionTypes';
 
 class SettingsForm extends React.Component {
   constructor() {
@@ -127,10 +132,10 @@ const mapStateToProps = state => ({
 });
 
 const mapDispatchToProps = dispatch => ({
-  onClickLogout: () => dispatch({ type: 'LOGOUT' }),
+  onClickLogout: () => dispatch({ type: LOGOUT }),
   onSubmitForm: user =>
-    dispatch({ type: 'SETTINGS_SAVED', payload: agent.Auth.save(user) }),
-  onUnload: () => dispatch({ type: 'SETTINGS_PAGE_UNLOADED' })
+    dispatch({ type: SETTINGS_SAVED, payload: agent.Auth.save(user) }),
+  onUnload: () => dispatch({ type: SETTINGS_PAGE_UNLOADED })
 });
 
 class Settings extends React.Component {

src/constants/actionTypes.js

@@ -0,0 +1,36 @@
+export const APP_LOAD = 'APP_LOAD';
+export const REDIRECT = 'REDIRECT';
+export const ARTICLE_SUBMITTED = 'ARTICLE_SUBMITTED';
+export const SETTINGS_SAVED = 'SETTINGS_SAVED';
+export const DELETE_ARTICLE = 'DELETE_ARTICLE';
+export const SETTINGS_PAGE_UNLOADED = 'SETTINGS_PAGE_UNLOADED';
+export const HOME_PAGE_LOADED = 'HOME_PAGE_LOADED';
+export const HOME_PAGE_UNLOADED = 'HOME_PAGE_UNLOADED';
+export const ARTICLE_PAGE_LOADED = 'ARTICLE_PAGE_LOADED';
+export const ARTICLE_PAGE_UNLOADED = 'ARTICLE_PAGE_UNLOADED';
+export const ADD_COMMENT = 'ADD_COMMENT';
+export const DELETE_COMMENT = 'DELETE_COMMENT';
+export const ARTICLE_FAVORITED = 'ARTICLE_FAVORITED';
+export const ARTICLE_UNFAVORITED = 'ARTICLE_UNFAVORITED';
+export const SET_PAGE = 'SET_PAGE';
+export const APPLY_TAG_FILTER = 'APPLY_TAG_FILTER';
+export const CHANGE_TAB = 'CHANGE_TAB';
+export const PROFILE_PAGE_LOADED = 'PROFILE_PAGE_LOADED';
+export const PROFILE_PAGE_UNLOADED = 'PROFILE_PAGE_UNLOADED';
+export const PROFILE_FAVORITES_PAGE_LOADED = 'PROFILE_FAVORITES_PAGE_LOADED';
+export const PROFILE_FAVORITES_PAGE_UNLOADED = 'PROFILE_FAVORITES_PAGE_UNLOADED';
+export const LOGIN = 'LOGIN';
+export const LOGOUT = 'LOGOUT';
+export const REGISTER = 'REGISTER';
+export const LOGIN_PAGE_UNLOADED = 'LOGIN_PAGE_UNLOADED';
+export const REGISTER_PAGE_UNLOADED = 'REGISTER_PAGE_UNLOADED';
+export const ASYNC_START = 'ASYNC_START';
+export const ASYNC_END = 'ASYNC_END';
+export const EDITOR_PAGE_LOADED = 'EDITOR_PAGE_LOADED';
+export const EDITOR_PAGE_UNLOADED = 'EDITOR_PAGE_UNLOADED';
+export const ADD_TAG = 'ADD_TAG';
+export const REMOVE_TAG = 'REMOVE_TAG';
+export const UPDATE_FIELD_AUTH = 'UPDATE_FIELD_AUTH';
+export const UPDATE_FIELD_EDITOR = 'UPDATE_FIELD_EDITOR';
+export const FOLLOW_USER = 'FOLLOW_USER';
+export const UNFOLLOW_USER = 'UNFOLLOW_USER';