Skip to content

Commit fbc1676

Browse files
committed
[SR-1901] Remove workarounds for private symbols
[SR-1901](https://bugs.swift.org/browse/SR-1901) has been fixed, we no longer need these workarounds.
1 parent 01676a2 commit fbc1676

File tree

3 files changed

+5
-20
lines changed

3 files changed

+5
-20
lines changed

Sources/XCTest/Public/XCAbstractTest.swift

+1-6
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,7 @@ open class XCTest {
3434

3535
/// The test run object that executed the test, an instance of
3636
/// testRunClass. If the test has not yet been run, this will be nil.
37-
/// - Note: FIXME: This property is meant to be `private(set)`. It is
38-
/// publicly settable for now due to a Swift compiler bug on Linux. To
39-
/// ensure compatibility of tests between swift-corelibs-xctest and Apple
40-
/// XCTest, you should not set this property. See
41-
/// https://bugs.swift.org/browse/SR-1129 for details.
42-
open open(set) var testRun: XCTestRun? = nil
37+
open private(set) var testRun: XCTestRun? = nil
4338

4439
/// The method through which tests are executed. Must be overridden by
4540
/// subclasses.

Sources/XCTest/Public/XCTestCase.swift

+3-8
Original file line numberDiff line numberDiff line change
@@ -41,22 +41,17 @@ open class XCTestCase: XCTest {
4141
return _name
4242
}
4343
/// A private setter for the name of this test case.
44-
/// - Note: FIXME: This property should be readonly, but currently has to
45-
/// be publicly settable due to a Swift compiler bug on Linux. To ensure
46-
/// compatibility of tests between swift-corelibs-xctest and Apple XCTest,
47-
/// this property should not be modified. See
48-
/// https://bugs.swift.org/browse/SR-1129 for details.
49-
public var _name: String
44+
private var _name: String
5045

5146
open override var testCaseCount: UInt {
5247
return 1
5348
}
5449

5550
/// The set of expectations made upon this test case.
56-
final internal var _allExpectations = [XCTestExpectation]()
51+
internal var _allExpectations = [XCTestExpectation]()
5752

5853
/// An internal object implementing performance measurements.
59-
final internal var _performanceMeter: PerformanceMeter?
54+
internal var _performanceMeter: PerformanceMeter?
6055

6156
open override var testRunClass: AnyClass? {
6257
return XCTestCaseRun.self

Sources/XCTest/Public/XCTestSuite.swift

+1-6
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,7 @@ open class XCTestSuite: XCTest {
2727
return _name
2828
}
2929
/// A private setter for the name of this test suite.
30-
/// - Note: FIXME: This property should be readonly, but currently has to
31-
/// be publicly settable due to a Swift compiler bug on Linux. To ensure
32-
/// compatibility of tests between swift-corelibs-xctest and Apple XCTest,
33-
/// this property should not be modified. See
34-
/// https://bugs.swift.org/browse/SR-1129 for details.
35-
public let _name: String
30+
private let _name: String
3631

3732
/// The number of test cases in this suite.
3833
open override var testCaseCount: UInt {

0 commit comments

Comments
 (0)