feat: implement compression stream in c++ #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabbou
changed the title
Merged
mani3xis
approved these changes
Nov 12, 2024
| controller.enqueue(new Uint8Array(compressedData)) | ||
| } catch (error) { | ||
| console.error(error) | ||
| } | ||
| }, | ||
| flush(controller) { |
There was a problem hiding this comment.
[nit] This is not a standard method. Can we get rid of it, and automatically flush when the stream is closed?
grabbou
added a commit
that referenced
this pull request
Nov 12, 2024
* init * fix * Revert changes' * fix: android build * chore: tweaks * chore: share const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpp zlib is better, writes headers automatically, so we can get rid of that logic.
As a next step, I guess we could implement streams in C++, but unfortunately, we can't pass them as arguments to Swift/Kotlin HybridObjects, so in case there's a platform API that want to consume stream, this would not work.
So maybe in the future, I talk to Marc at the conference about this.