feat: scaffold Android part in Kotlin #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
grabbou
commented
Nov 1, 2024
•
grabbou
commented
- for now, will throw an error
- upgraded to latest nitro (and latest codegen) and regenerated sources
- upgraded to latest React Native and updated template accordingly
- updated package namespaces to match closely what other Nitro packages do
- clean up peer dependencies / dependencies situation for the package and clearly set requirements for React Native
|
In a follow-up PR, I will implement basic functionality for sending and receiving messages so that we can begin comparing performance. |
grabbou
changed the title
dratwas
reviewed
Nov 1, 2024
| @@ -7,7 +7,7 @@ import { | |||
| import { NitroModules } from 'react-native-nitro-modules' | |||
|
|
|||
| import { Blob } from './blob' | |||
| import { WebSocket as HybridWebSocket, WebSocketManager } from './spec.nitro' | |||
| import { WebSocket as HybridWebSocket, WebSocketManager } from './WebSocket.nitro' | |||
There was a problem hiding this comment.
Is the WebSocket.nitro a valid name of the file? I can see that it is still spec.nitro in this PR
There was a problem hiding this comment.
Yeah mistake 😂 Fixed later! I was just checking you 👀
dratwas
approved these changes
Nov 1, 2024
grabbou
added a commit
that referenced
this pull request
Nov 2, 2024
* chore: initial commit * initial android working build * chore: link package * tweaks * feat: building version * chore: working prototype verified * chore: complete stubbing it out * clean up deps * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.