feat: implement HybridWebSocket on Android #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabbou
commented
Nov 1, 2024
| @@ -126,6 +126,9 @@ dependencies { | |||
|
|
|||
| // Add a dependency on NitroModules | |||
| implementation project(":react-native-nitro-modules") | |||
|
|
|||
| // Let's use whatever React Native uses right now to avoid duplicates | |||
| implementation "com.squareup.okhttp3:okhttp:+" | |||
There was a problem hiding this comment.
Not sure if this is correct, have to check 🤣
|
Performance benchmark. |
grabbou
changed the title
dratwas
reviewed
Nov 1, 2024
example/App.tsx
Outdated
| @@ -122,7 +122,9 @@ const testWebsocketMessages = async (opts: { | |||
| incomingTime: number | |||
| }> => | |||
| new Promise((resolve) => { | |||
| const inst = new opts.Ws('ws://localhost:3000') | |||
| const inst = new opts.Ws( | |||
| Platform.OS === 'android' ? 'ws://10.0.2.2:3000' : 'ws://localhost:3000' | |||
There was a problem hiding this comment.
We should probably move it to some config file
dratwas
reviewed
Nov 1, 2024
...es/react-native-fast-ws/android/src/main/java/com/margelo/nitro/websocket/HybridWebSocket.kt
Show resolved
Hide resolved
dratwas
approved these changes
Nov 1, 2024
grabbou
added a commit
that referenced
this pull request
Nov 2, 2024
* chore: add initial implementation * revert changes * chore: stub URL * chore: remove todo * chore: add onclosed * chore: move to const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides actual implementation for WebSocket module for Android, using okhttp in Kotlin. This is similar to how/what React Native does.
This is WIP. Functionality is missing. Reviews are welcome.