Add CodeNarc checks

Author: lptr

build.gradle

@@ -14,6 +14,7 @@ buildscript {
 apply plugin: 'groovy'
 apply plugin: 'java-gradle-plugin'
 apply plugin: 'maven'
+apply plugin: 'codenarc'
 
 apply plugin: "com.gradle.plugin-publish"
 

config/codenarc/codenarc.xml

@@ -0,0 +1,43 @@
+<!--
+  ~ Copyright 2017 the original author or authors.
+  ~
+  ~ Licensed under the Apache License, Version 2.0 (the "License");
+  ~ you may not use this file except in compliance with the License.
+  ~ You may obtain a copy of the License at
+  ~
+  ~      http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+<ruleset xmlns="http://codenarc.org/ruleset/1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://codenarc.org/ruleset/1.0 http://codenarc.org/ruleset-schema.xsd"
+         xsi:noNamespaceSchemaLocation="http://codenarc.org/ruleset-schema.xsd">
+    <ruleset-ref path='rulesets/braces.xml'/>
+    <ruleset-ref path='rulesets/imports.xml'>
+        <exclude name="ImportFromSunPackages"/>
+        <exclude name="MisorderedStaticImports"/>
+        <exclude name="NoWildcardImports"/>
+    </ruleset-ref>
+    <ruleset-ref path='rulesets/naming.xml'>
+        <rule-config name='ClassName'>
+            <property name='regex' value='^[A-Z][\$a-zA-Z0-9_]*$'/>
+        </rule-config>
+        <rule-config name='FieldName'>
+            <property name='finalRegex' value='^[a-z][a-zA-Z0-9]*$'/>
+            <property name='staticFinalRegex' value='^logger$|^[A-Z][A-Z_0-9]*$|^serialVersionUID$'/>
+        </rule-config>
+        <rule-config name='MethodName'>
+            <property name='regex' value='^[a-z][\$_a-zA-Z0-9]*$|^.*\s.*$'/>
+        </rule-config>
+        <rule-config name='VariableName'>
+            <property name='finalRegex' value='^[a-z][a-zA-Z0-9]*$'/>
+        </rule-config>
+        <exclude name="ConfusingMethodName"/>
+        <exclude name="FactoryMethodName"/>
+        <exclude name="ClassNameSameAsSuperclass"/>
+    </ruleset-ref>
+</ruleset>

src/main/groovy/org/gradle/android/AndroidCacheFixPlugin.groovy

@@ -26,7 +26,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
 
     private static final String IGNORE_VERSION_CHECK_PROPERTY = "org.gradle.android.cache-fix.ignoreVersionCheck"
 
-    private static List<Workaround> WORKAROUNDS = [
+    private static final List<Workaround> WORKAROUNDS = [
         new AndroidJavaCompile_BootClasspath_Workaround(),
         new AndroidJavaCompile_AnnotationProcessorSource_Workaround(),
         new AndroidJavaCompile_ProcessorListFile_Workaround(),