Skip to content

Commit fa66728

Browse files
committed
simplifying implementation
1 parent cf86322 commit fa66728

File tree

1 file changed

+6
-27
lines changed

1 file changed

+6
-27
lines changed

src/main/groovy/org/gradle/android/workarounds/JdkImageWorkaround.groovy

Lines changed: 6 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,8 @@ class JdkImageWorkaround implements Workaround {
5353
applyRuntimeClasspathNormalization(project)
5454

5555
applyToAllAndroidVariants(project) { variant ->
56-
if (Versions.CURRENT_ANDROID_VERSION <= VersionNumber.parse("7.4.0-alpha01")) {
57-
variant.javaCompileProvider.configure { JavaCompile task ->
58-
jdkTransform(project, task)
59-
}
60-
} else {
61-
project.afterEvaluate {
62-
project.tasks.withType(JavaCompile).configureEach { task ->
63-
jdkTransform(project, task)
64-
}
65-
}
56+
variant.javaCompileProvider.configure { JavaCompile task ->
57+
jdkTransform(project, task)
6658
}
6759
}
6860
}
@@ -75,15 +67,9 @@ class JdkImageWorkaround implements Workaround {
7567
}
7668
}
7769

70+
// Configuration for Old Variant API will drop in AGP 9. We will need to use a different
71+
// approach to retrieve the variants using the new Variant API.
7872
private static void applyToAllAndroidVariants(Project project, Closure<?> configureVariant) {
79-
if (Versions.CURRENT_ANDROID_VERSION <= VersionNumber.parse("7.4.0-alpha01")) {
80-
applyToAllAndroidVariantsWithOldVariantApi(project, configureVariant)
81-
} else {
82-
applyToAllAndroidVariantsWithNewVariantApi(project, configureVariant)
83-
}
84-
}
85-
86-
private static void applyToAllAndroidVariantsWithOldVariantApi(Project project, Closure<?> configureVariant) {
8773
project.plugins.withId("com.android.application") {
8874
def android = project.extensions.findByName("android")
8975
android.unitTestVariants.all(configureVariant)
@@ -97,14 +83,6 @@ class JdkImageWorkaround implements Workaround {
9783
}
9884
}
9985

100-
private static void applyToAllAndroidVariantsWithNewVariantApi(Project project, Closure<?> configureVariant) {
101-
project.plugins.withId("com.android.base") {
102-
def androidComponents = project.extensions.findByName("androidComponents")
103-
def selector = androidComponents.selector()
104-
androidComponents.onVariants(selector.all(), configureVariant)
105-
}
106-
}
107-
10886
static def applyRuntimeClasspathNormalization(Project project) {
10987
project.normalization { handler ->
11088
handler.runtimeClasspath {
@@ -188,6 +166,7 @@ class JdkImageWorkaround implements Workaround {
188166
interface Parameters extends TransformParameters {
189167
@Internal
190168
Provider<Directory> getJavaHome()
169+
191170
void setJavaHome(Provider<Directory> javaHome)
192171
}
193172

@@ -254,7 +233,7 @@ class JdkImageWorkaround implements Workaround {
254233

255234
private static String serializeRequires(ModuleDescriptor.Requires requires) {
256235
String requireString
257-
if (! requires.compiledVersion().empty) {
236+
if (!requires.compiledVersion().empty) {
258237
requireString = requires.name() + " (@" + requires.compiledVersion() + ")"
259238
} else {
260239
requireString = requires.name()

0 commit comments

Comments
 (0)