Use default value when accessing un-initialized Property

Accessing an uninitialized Property is illegal, resulting in errors or warnings when
CCUDGP is applied with no value set for 'server'.
This is fixed by providing a default value to use in the case of uninitialized Property.

Fixes gradle/common-custom-user-data-gradle-plugin#378

Author: bigdaz

Diff for: develocity-gradle-plugin-adapters/src/compatibilityApi/java/com/gradle/develocity/agent/gradle/adapters/internal/ReflectionProperty.java

@@ -57,10 +57,14 @@ public static <T> ReflectionProperty<T> forGetterAndSetter(Object obj, String ge
     }
 
     public static <T> ReflectionProperty<T> forProperty(Object obj, String propertyName) {
+        return forProperty(obj, propertyName, null);
+    }
+
+    public static <T> ReflectionProperty<T> forProperty(Object obj, String propertyName, T defaultValue) {
         return new ReflectionProperty<>(
             () -> {
                 Property<T> prop = (Property<T>) invokeMethod(obj, propertyName);
-                return prop.get();
+                return prop.getOrElse(defaultValue);
             },
             value -> {
                 Property<T> prop = (Property<T>) invokeMethod(obj, propertyName);

Diff for: develocity-gradle-plugin-adapters/src/develocityCompatibility/java/com/gradle/develocity/agent/gradle/adapters/develocity/BuildScanCaptureConfigurationAdapter.java

@@ -37,9 +37,9 @@ public static BuildScanCaptureAdapter forBuildScanExtension(Object buildScan) {
     @VisibleForTesting
     static @NotNull ReflectingBuildScanCaptureAdapter forCaptureConfiguration(Object capture) {
         return new ReflectingBuildScanCaptureAdapter(
-            ReflectionProperty.forProperty(capture, "getFileFingerprints"),
-            ReflectionProperty.forProperty(capture, "getBuildLogging"),
-            ReflectionProperty.forProperty(capture, "getTestLogging")
+            ReflectionProperty.forProperty(capture, "getFileFingerprints", true),
+            ReflectionProperty.forProperty(capture, "getBuildLogging", true),
+            ReflectionProperty.forProperty(capture, "getTestLogging", true)
         );
     }
 }

Diff for: develocity-gradle-plugin-adapters/src/develocityCompatibility/java/com/gradle/develocity/agent/gradle/adapters/develocity/BuildScanConfigurationAdapter.java

@@ -54,7 +54,7 @@ protected ReflectionProperty<String> getTermsOfUseAgreeProperty() {
 
     @Override
     protected ReflectionProperty<Boolean> getUploadInBackgroundProperty() {
-        return ReflectionProperty.forProperty(buildScanExtension, "getUploadInBackground");
+        return ReflectionProperty.forProperty(buildScanExtension, "getUploadInBackground", true);
     }
 
     @Nullable

Diff for: develocity-gradle-plugin-adapters/src/develocityCompatibility/java/com/gradle/develocity/agent/gradle/adapters/develocity/DevelocityConfigurationAdapter.java

@@ -55,7 +55,7 @@ protected ReflectionProperty<String> getProjectIdProperty() {
 
     @Override
     protected ReflectionProperty<Boolean> getAllowUntrustedServerProperty() {
-        return ReflectionProperty.forProperty(extension, "getAllowUntrustedServer");
+        return ReflectionProperty.forProperty(extension, "getAllowUntrustedServer", true);
     }
 
     @Override

Diff for: develocity-gradle-plugin-adapters/src/develocityCompatibilityTest/java/com/gradle/develocity/agent/gradle/adapters/develocity/BuildScanConfigurationAdapterTest.java

@@ -137,7 +137,7 @@ void testUploadInBackground() {
         adapter.isUploadInBackground();
 
         // then
-        verify(configuration.getUploadInBackground()).get();
+        verify(configuration.getUploadInBackground()).getOrElse(true);
     }
 
     @Test

Diff for: develocity-gradle-plugin-adapters/src/testFixtures/java/com/gradle/develocity/agent/gradle/adapters/PropertyMockFixtures.java

@@ -2,6 +2,7 @@
 
 import org.gradle.api.provider.Property;
 
+import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.lenient;
 import static org.mockito.Mockito.mock;
 
@@ -20,6 +21,7 @@ public static <T> Property<T> mockPropertyReturning(T value) {
         Property<T> prop = (Property<T>) mock(Property.class);
         lenient().when(prop.get()).thenReturn(value);
         lenient().when(prop.getOrNull()).thenReturn(value);
+        lenient().when(prop.getOrElse(any())).thenReturn(value);
         return prop;
     }