Skip to content

Commit 1d79e44

Browse files
authored
Merge pull request #664 from gradle/erichaagdev/clean-up-listeners
Listeners in bundled Maven extension are cleaned up and aligned with other Solutions repos
2 parents 839e6ae + 1c74cbe commit 1d79e44

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed

Diff for: components/configure-gradle-enterprise-maven-extension/build.gradle.kts

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ repositories {
99

1010
dependencies {
1111
compileOnly("org.apache.maven:maven-core:3.6.3") // intentionally compiling against an older version to preserve compatibility with older versions of Maven
12-
compileOnly("org.codehaus.plexus:plexus-component-annotations:2.2.0")
1312
compileOnly("com.gradle:develocity-maven-extension:1.22.1")
1413
implementation("com.gradle:develocity-maven-extension-adapters:1.0")
1514
}

Diff for: components/configure-gradle-enterprise-maven-extension/src/main/java/com/gradle/ConfigureDevelocity.java renamed to components/configure-gradle-enterprise-maven-extension/src/main/java/com/gradle/ConfigureDevelocityListener.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,18 @@
77

88
import javax.inject.Inject;
99

10-
public class ConfigureDevelocity implements DevelocityListener {
10+
public class ConfigureDevelocityListener implements DevelocityListener {
1111

1212
private final ConfigureDevelocityAdaptor configureDevelocityAdaptor;
1313

1414
@Inject
15-
public ConfigureDevelocity(ConfigureDevelocityAdaptor configureDevelocityAdaptor, RootProjectExtractor rootProjectExtractor) {
15+
public ConfigureDevelocityListener(ConfigureDevelocityAdaptor configureDevelocityAdaptor) {
1616
this.configureDevelocityAdaptor = configureDevelocityAdaptor;
1717
}
1818

1919
@Override
2020
public void configure(DevelocityApi api, MavenSession session) {
2121
configureDevelocityAdaptor.configure(new DevelocityApiAdapter(api), session);
2222
}
23+
2324
}

Diff for: components/configure-gradle-enterprise-maven-extension/src/main/java/com/gradle/ConfigureGradleEnterprise.java renamed to components/configure-gradle-enterprise-maven-extension/src/main/java/com/gradle/ConfigureGradleEnterpriseListener.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,19 @@
66
import javax.inject.Inject;
77

88
// Using fully qualified class names to avoid deprecation warnings on import statements
9-
@SuppressWarnings({"deprecation"})
10-
public class ConfigureGradleEnterprise implements com.gradle.maven.extension.api.GradleEnterpriseListener {
9+
@SuppressWarnings("deprecation")
10+
public class ConfigureGradleEnterpriseListener implements com.gradle.maven.extension.api.GradleEnterpriseListener {
1111

1212
private final ConfigureDevelocityAdaptor configureDevelocityAdaptor;
1313

1414
@Inject
15-
public ConfigureGradleEnterprise(ConfigureDevelocityAdaptor configureDevelocityAdaptor) {
15+
public ConfigureGradleEnterpriseListener(ConfigureDevelocityAdaptor configureDevelocityAdaptor) {
1616
this.configureDevelocityAdaptor = configureDevelocityAdaptor;
1717
}
1818

1919
@Override
2020
public void configure(com.gradle.maven.extension.api.GradleEnterpriseApi api, MavenSession session) {
2121
configureDevelocityAdaptor.configure(new GradleEnterpriseApiAdapter(api), session);
2222
}
23+
2324
}

Diff for: components/configure-gradle-enterprise-maven-extension/src/main/resources/META-INF/plexus/components.xml

+7-6
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
<component-set>
22
<components>
33
<component>
4+
<!--suppress DeprecatedClassUsageInspection -->
45
<role>com.gradle.maven.extension.api.GradleEnterpriseListener</role>
5-
<role-hint>configure-gradle-enterprise</role-hint>
6-
<implementation>com.gradle.ConfigureGradleEnterprise</implementation>
7-
<description>Configures Gradle Enterprise</description>
6+
<role-hint>configure-gradle-enterprise-listener</role-hint>
7+
<implementation>com.gradle.ConfigureGradleEnterpriseListener</implementation>
8+
<description>Configures the Gradle Enterprise Maven extension</description>
89
<isolated-realm>false</isolated-realm>
910
</component>
1011
<component>
1112
<role>com.gradle.develocity.agent.maven.api.DevelocityListener</role>
12-
<role-hint>configure-develocity</role-hint>
13-
<implementation>com.gradle.ConfigureDevelocity</implementation>
14-
<description>Configures Develocity</description>
13+
<role-hint>configure-develocity-listener</role-hint>
14+
<implementation>com.gradle.ConfigureDevelocityListener</implementation>
15+
<description>Configures the Develocity Maven extension</description>
1516
<isolated-realm>false</isolated-realm>
1617
</component>
1718
</components>

0 commit comments

Comments
 (0)