Merge pull request #524 from gradle/erichaagdev/disable-pts

Predictive Test Selection is disabled when running builds

Author: erichaagdev

Diff for: components/scripts/gradle/01-validate-incremental-building.sh

@@ -136,7 +136,7 @@ execute_build() {
 }
 
 print_gradle_command() {
-    info "./gradlew --no-build-cache -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} $*$(print_extra_args)"
+    info "./gradlew --no-build-cache -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} -Dpts.enabled=false $*$(print_extra_args)"
 }
 
 fetch_build_cache_metrics() {

Diff for: components/scripts/gradle/02-validate-local-build-caching-same-location.sh

@@ -141,7 +141,7 @@ execute_build() {
 }
 
 print_gradle_command() {
-  info "./gradlew --build-cache -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
+  info "./gradlew --build-cache -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} -Dpts.enabled=false clean ${tasks}$(print_extra_args)"
 }
 
 fetch_build_cache_metrics() {

Diff for: components/scripts/gradle/03-validate-local-build-caching-different-locations.sh

@@ -146,7 +146,7 @@ execute_build() {
 }
 
 print_gradle_command() {
-  info "./gradlew --build-cache -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
+  info "./gradlew --build-cache -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} -Dpts.enabled=false clean ${tasks}$(print_extra_args)"
 }
 
 fetch_build_cache_metrics() {

Diff for: components/scripts/gradle/04-validate-remote-build-caching-ci-ci.sh

@@ -192,6 +192,11 @@ Make sure the CI configuration uses the proper branch and performs a fresh
 checkout to avoid any build artifacts lingering around from a previous build
 that could influence the experiment.
 
+Also, make sure the CI configuration builds the project with Predictive Test
+Selection (PTS) disabled, as test results will not be stored in the build cache
+when only a subset of tests are selected for execution. PTS can be globally
+disabled using the '-Dpts.enabled=false' system property.
+
 Once the build completes, make a note of the commit id that was used, and enter
 the URL of the build scan produced by the build.
 EOF

Diff for: components/scripts/gradle/05-validate-remote-build-caching-ci-local.sh

@@ -204,7 +204,7 @@ execute_build() {
   args+=(clean ${tasks})
 
   info "Running build:"
-  info "./gradlew --build-cache -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
+  info "./gradlew --build-cache -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} -Dpts.enabled=false clean ${tasks}$(print_extra_args)"
 
   invoke_gradle 1 "${args[@]}"
 }
@@ -284,6 +284,11 @@ Make sure the CI configuration uses the proper branch and performs a fresh
 checkout to avoid any build artifacts lingering around from a previous build
 that could influence the experiment.
 
+Also, make sure the CI configuration builds the project with Predictive Test
+Selection (PTS) disabled, as test results will not be stored in the build cache
+when only a subset of tests are selected for execution. PTS can be globally
+disabled using the '-Dpts.enabled=false' system property.
+
 Once the build completes, make a note of the commit id that was used, and enter
 the URL of the build scan produced by the build.
 EOF

Diff for: components/scripts/lib/gradle.sh

@@ -32,6 +32,7 @@ invoke_gradle() {
     -Dcom.gradle.enterprise.build-validation.runNum="${run_num}"
     -Dcom.gradle.enterprise.build-validation.scriptsVersion="${SCRIPT_VERSION}"
     -Dscan.capture-task-input-files=true
+    -Dpts.enabled=false
   )
 
   # https://stackoverflow.com/a/31485948

Diff for: components/scripts/lib/maven.sh

@@ -58,6 +58,7 @@ invoke_maven() {
     -Dcom.gradle.enterprise.build-validation.runNum="${run_num}"
     -Dcom.gradle.enterprise.build-validation.scriptsVersion="${SCRIPT_VERSION}"
     -Dgradle.scan.captureGoalInputFiles=true
+    -Dpts.enabled=false
   )
 
   # https://stackoverflow.com/a/31485948

Diff for: components/scripts/maven/01-validate-local-build-caching-same-location.sh

@@ -142,7 +142,7 @@ execute_build() {
 }
 
 print_maven_command() {
-   info "./mvnw -Dscan -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
+   info "./mvnw -Dscan -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} -Dpts.enabled=false clean ${tasks}$(print_extra_args)"
  }
 
 fetch_build_cache_metrics() {

Diff for: components/scripts/maven/02-validate-local-build-caching-different-locations.sh

@@ -146,7 +146,7 @@ execute_build() {
 }
 
 print_maven_command() {
-  info "./mvnw -Dscan -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
+  info "./mvnw -Dscan -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} -Dpts.enabled=false clean ${tasks}$(print_extra_args)"
 }
 
 fetch_build_cache_metrics() {

Diff for: components/scripts/maven/03-validate-remote-build-caching-ci-ci.sh

@@ -190,6 +190,11 @@ Make sure the CI configuration uses the proper branch and performs a fresh
 checkout to avoid any build artifacts lingering around from a previous build
 that could influence the experiment.
 
+Also, make sure the CI configuration builds the project with Predictive Test
+Selection (PTS) disabled, as test results will not be stored in the build cache
+when only a subset of tests are selected for execution. PTS can be globally
+disabled using the '-Dpts.enabled=false' system property.
+
 Once the build completes, make a note of the commit id that was used, and enter
 the URL of the build scan produced by the build.
 EOF

Diff for: components/scripts/maven/04-validate-remote-build-caching-ci-local.sh

@@ -202,7 +202,7 @@ execute_build() {
   args+=(clean ${tasks})
 
   info "Running build:"
-  info "./mvnw -Dscan -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
+  info "./mvnw -Dscan -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} -Dpts.enabled=false clean ${tasks}$(print_extra_args)"
 
   # shellcheck disable=SC2086  # we want tasks to expand with word splitting in this case
   invoke_maven 1 "${args[@]}"
@@ -284,6 +284,11 @@ Make sure the CI configuration uses the proper branch and performs a fresh
 checkout to avoid any build artifacts lingering around from a previous build
 that could influence the experiment.
 
+Also, make sure the CI configuration builds the project with Predictive Test
+Selection (PTS) disabled, as test results will not be stored in the build cache
+when only a subset of tests are selected for execution. PTS can be globally
+disabled using the '-Dpts.enabled=false' system property.
+
 Once the build completes, make a note of the commit id that was used, and enter
 the URL of the build scan produced by the build.
 EOF

Diff for: release/changes.md

@@ -1 +1 @@
-- [NEW] TBD
+- [NEW] Predictive Test Selection is disabled when running builds