Upgrade Shellcheck to v0.10.0 (#612)

Also address new style issues flagged by the updated Shellcheck version

Fixes [SC2004](https://www.shellcheck.net/wiki/SC2004).

Author: jthurne

build.gradle.kts

@@ -55,7 +55,7 @@ dependencies {
 
 shellcheck {
     additionalArguments = "-a -x"
-    shellcheckVersion = "v0.8.0"
+    shellcheckVersion = "v0.10.0"
 }
 
 val unpackArgbash by tasks.registering(Copy::class) {

components/scripts/lib/build-scan-online.sh

@@ -28,10 +28,10 @@ read_build_scan_metadata() {
 
     # shellcheck disable=SC2034
     while IFS=, read -r run_num project_name base_url build_scan_url build_scan_id; do
-       project_names[$run_num]="${project_name}"
-       base_urls[$run_num]="${base_url}"
-       build_scan_urls[$run_num]="${build_scan_url}"
-       build_scan_ids[$run_num]="${build_scan_id}"
+       project_names[run_num]="${project_name}"
+       base_urls[run_num]="${base_url}"
+       build_scan_urls[run_num]="${build_scan_url}"
+       build_scan_ids[run_num]="${build_scan_id}"
     done <<< "${build_scan_metadata}"
   fi
 }