Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve experience when dualPublish is configured #796

Open
erichaagdev opened this issue Feb 4, 2025 · 0 comments
Open

Improve experience when dualPublish is configured #796

erichaagdev opened this issue Feb 4, 2025 · 0 comments

Comments

@erichaagdev
Copy link
Member

The following 2 problems exist when dualPublish is configured:

  • If the secondary publish succeeds, its build scan is written to the build-scans.csv file and its build scans are used to create the summary
  • If the secondary publish fails but the primary publish succeeds, the experiment aborts (see below)

Image

We should consider making the following changes:

  • If the secondary publish succeeds, do not write its contents to build-scans.csv and always use the build scans from the primary publish to create the summary
  • If the secondary publish fails but the primary publish succeeds, do not abort the experiment and continue

We need to confirm that the callbacks from the primary publish will always complete before the callbacks of the dualPublish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant