Merge pull request #4 from grafana/chore/linting

Chore: Lint with golangci-lint

Author: aknuds1

Diff for: .golangci.toml

@@ -0,0 +1,83 @@
+[run]
+timeout = "10m"
+
+[linters-settings.golint]
+min-confidence = 3
+
+[linters-settings.goconst]
+min-len = 5
+min-occurrences = 5
+
+[linters]
+disable-all = true
+enable = [
+  "bodyclose",
+  "deadcode",
+  "depguard",
+  "dogsled",
+  "errcheck",
+  "gochecknoinits",
+  "goconst",
+  "gocritic",
+  "goimports",
+  "golint",
+  "goprintffuncname",
+  "gosec",
+  "gosimple",
+  "govet",
+  "ineffassign",
+  "misspell",
+  "nakedret",
+  "rowserrcheck",
+  "exportloopref",
+  "staticcheck",
+  "structcheck",
+  #"stylecheck",
+  "typecheck",
+  "unconvert",
+  "unused",
+  "varcheck",
+  "whitespace",
+  "gocyclo",
+  "unparam",
+]
+
+[[issues.exclude-rules]]
+linters = ["gosec"]
+text = "G108"
+
+[[issues.exclude-rules]]
+linters = ["gosec"]
+text = "G110"
+
+[[issues.exclude-rules]]
+linters = ["gosec"]
+text = "G201"
+
+[[issues.exclude-rules]]
+linters = ["gosec"]
+text = "G202"
+
+[[issues.exclude-rules]]
+linters = ["gosec"]
+text = "G306"
+
+[[issues.exclude-rules]]
+linters = ["gosec"]
+text = "401"
+
+[[issues.exclude-rules]]
+linters = ["gosec"]
+text = "402"
+
+[[issues.exclude-rules]]
+linters = ["gosec"]
+text = "501"
+
+[[issues.exclude-rules]]
+linters = ["gosec"]
+text = "404"
+
+[[issues.exclude-rules]]
+linters = ["misspell"]
+text = "Unknwon` is a misspelling of `Unknown"

Diff for: client.go

@@ -23,8 +23,8 @@ type Client struct {
 	*http.Client
 }
 
-//New creates a new grafana client
-//auth can be in user:pass format, or it can be an api key
+// New creates a new grafana client.
+// auth can be in user:pass format, or it can be an api key
 func New(auth, baseURL string) (*Client, error) {
 	u, err := url.Parse(baseURL)
 	if err != nil {
@@ -54,6 +54,7 @@ func (c *Client) request(method, requestPath string, query url.Values, body io.R
 	if err != nil {
 		return err
 	}
+	defer resp.Body.Close()
 
 	bodyContents, err := ioutil.ReadAll(resp.Body)
 	if err != nil {

Diff for: folder_permissions_test.go

@@ -1,8 +1,9 @@
 package gapi
 
 import (
-	"github.com/gobs/pretty"
 	"testing"
+
+	"github.com/gobs/pretty"
 )
 
 const (

Diff for: team.go

@@ -80,7 +80,7 @@ func (c *Client) Team(id int64) (*Team, error) {
 // email arg is an optional value.
 // If you don't want to set email, please set "" (empty string).
 func (c *Client) AddTeam(name string, email string) error {
-	path := fmt.Sprintf("/api/teams")
+	path := "/api/teams"
 	team := Team{
 		Name:  name,
 		Email: email,

Diff for: teams_test.go

@@ -1,8 +1,9 @@
 package gapi
 
 import (
-	"github.com/gobs/pretty"
 	"testing"
+
+	"github.com/gobs/pretty"
 )
 
 const (
@@ -145,7 +146,7 @@ func TestTeam(t *testing.T) {
 		Permission:  0,
 	}
 	t.Run("check data", func(t *testing.T) {
-		if expect.Id != resp.Id || expect.Name != expect.Name {
+		if resp.Id != expect.Id || resp.Name != expect.Name {
 			t.Error("Not correctly parsing returned team.")
 		}
 	})