Skip to content

Commit 5709aa7

Browse files
suchsoonmstoykov
authored andcommitted
fix some comments
Signed-off-by: suchsoon <[email protected]>
1 parent 2e3920c commit 5709aa7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

docs/design/020-distributed-execution-and-test-suites.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ type Controller interface {
109109
// error are saved for the ID and returned for all other calls with it.
110110
//
111111
// This is an atomic function, so any calls to it while the callback is
112-
// being executed the the same ID will wait for the first call to finish
112+
// being executed the same ID will wait for the first call to finish
113113
// and receive its result.
114114
GetOrCreateData(id string, callback func() ([]byte, error)) ([]byte, error)
115115

@@ -288,7 +288,7 @@ One proposal in the original posts of https://github.com/grafana/k6/issues/140 w
288288

289289
While there were some details in the original proposal that are no longer applicable because of the big architectural changes in k6 in the meantime, the overall proposal is probably still valid. I am pretty sure that the architecture I proposed above can be built on top of these technologies and in a way where instances don't need to hold a persistent connection to a central `k6 coordinator` node!
290290

291-
However, I think that the benefits of such an approach would be outweighed by the drawbacks in terms of imlpementation and deployment complexity. In short, it can probably work, but IMO the UX will be worse. Even if we ignore the complications of deploying multiple software stacks (vs. just the k6 binary), it'd be difficult to implement great error handling and timely handling of things like `abortOnFail` thresholds and `test.abort()` API calls. It can certainly be done, but it'd be a ton of effort to not get a flaky experience...
291+
However, I think that the benefits of such an approach would be outweighed by the drawbacks in terms of implementation and deployment complexity. In short, it can probably work, but IMO the UX will be worse. Even if we ignore the complications of deploying multiple software stacks (vs. just the k6 binary), it'd be difficult to implement great error handling and timely handling of things like `abortOnFail` thresholds and `test.abort()` API calls. It can certainly be done, but it'd be a ton of effort to not get a flaky experience...
292292

293293
And, as I explained in the "High Availability" section above, a k6 test failing is not the worst thing that can happen. An inconsistent or a flaky test is a worse user experience in my mind.
294294

execution/controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ type Controller interface {
99
// error are saved for the ID and returned for all other calls with it.
1010
//
1111
// This is an atomic and single-flight function, so any calls to it while the callback is
12-
// being executed the the same ID will wait for the first call to to finish
12+
// being executed the same ID will wait for the first call to finish
1313
// and receive its result.
1414
//
1515
// TODO: split apart into `Once()`, `SetData(), `GetData()` and implement

0 commit comments

Comments
 (0)