Skip to content

Commit bde75eb

Browse files
nadiamoeRo Santalla
authored and
Ro Santalla
committed
k6runner: use non-pointer LocalRunner everywhere
Having some methods return a pointer version becomes tricky fast
1 parent 0a943f9 commit bde75eb

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

internal/k6runner/k6runner.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func New(opts RunnerOpts) Runner {
5757
logger: &logger,
5858
}
5959
} else {
60-
r = &LocalRunner{
60+
r = LocalRunner{
6161
k6path: opts.Uri,
6262
logger: &logger,
6363
blacklistedIP: opts.BlacklistedIP,

internal/k6runner/k6runner_test.go

+6-4
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,13 @@ import (
2424

2525
func TestNew(t *testing.T) {
2626
r1 := New(RunnerOpts{Uri: "k6"})
27-
require.IsType(t, &LocalRunner{}, r1)
28-
require.Equal(t, "", r1.(*LocalRunner).blacklistedIP)
27+
require.IsType(t, LocalRunner{}, r1)
28+
require.Equal(t, "", r1.(LocalRunner).blacklistedIP)
29+
2930
r2 := New(RunnerOpts{Uri: "/usr/bin/k6", BlacklistedIP: "192.168.4.0/24"})
30-
require.IsType(t, &LocalRunner{}, r2)
31-
require.Equal(t, "192.168.4.0/24", r2.(*LocalRunner).blacklistedIP)
31+
require.IsType(t, LocalRunner{}, r2)
32+
require.Equal(t, "192.168.4.0/24", r2.(LocalRunner).blacklistedIP)
33+
3234
r3 := New(RunnerOpts{Uri: "http://localhost:6565"})
3335
require.IsType(t, &HttpRunner{}, r3)
3436
r4 := New(RunnerOpts{Uri: "https://localhost:6565"})

0 commit comments

Comments
 (0)