Fix inability to update managed ML alerts

The ID field was not being populated by the plan so we were attempting
to create a new alert instead of updating the existing alert. The ID is
now pulled from the existing state and test coverage for the update path
was added.

Author: csmarchbanks

internal/resources/machinelearning/resource_alert.go

@@ -277,6 +277,13 @@ func (r *alertResource) Update(ctx context.Context, req resource.UpdateRequest,
 	if resp.Diagnostics.HasError() {
 		return
 	}
+	// It is required to fetch the ID from the state data. It is not present in the plan data.
+	var stateData resourceAlertModel
+	resp.Diagnostics.Append(req.State.Get(ctx, &stateData)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+	data.ID = stateData.ID
 
 	alert, err := alertFromModel(data)
 	if err != nil {
@@ -341,9 +348,9 @@ func (r *alertResource) read(ctx context.Context, model resourceAlertModel) (*re
 		err   error
 	)
 	if model.JobID.ValueString() != "" {
-		alert, err = r.mlapi.JobAlert(ctx, model.JobID.ValueString(), model.ID.String())
+		alert, err = r.mlapi.JobAlert(ctx, model.JobID.ValueString(), model.ID.ValueString())
 	} else {
-		alert, err = r.mlapi.OutlierAlert(ctx, model.OutlierID.ValueString(), model.ID.String())
+		alert, err = r.mlapi.OutlierAlert(ctx, model.OutlierID.ValueString(), model.ID.ValueString())
 	}
 	if err != nil {
 		return nil, diag.Diagnostics{diag.NewErrorDiagnostic("Unable to read resource", err.Error())}

internal/resources/machinelearning/resource_alert_test.go

@@ -18,7 +18,7 @@ func TestAccResourceJobAlert(t *testing.T) {
 	testutils.CheckCloudInstanceTestsEnabled(t)
 
 	randomJobName := acctest.RandomWithPrefix("Test Job")
-	randomAlertName := acctest.RandomWithPrefix("Test Job Alert")
+	randomAlertName := acctest.RandomWithPrefix("Test Alert")
 
 	var job mlapi.Job
 	var alert mlapi.Alert
@@ -37,6 +37,28 @@ func TestAccResourceJobAlert(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccMLJobCheckExists("grafana_machine_learning_job.test_alert_job", &job),
 					testAccMLJobAlertCheckExists("grafana_machine_learning_alert.test_job_alert", &job, &alert),
+					resource.TestCheckResourceAttrSet("grafana_machine_learning_alert.test_job_alert", "id"),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_job_alert", "title", randomAlertName),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_job_alert", "anomaly_condition", "any"),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_job_alert", "threshold", ">0.8"),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_job_alert", "window", "15m"),
+				),
+			},
+			// Update the alert with a new anomaly conditon.
+			{
+				Config: testutils.TestAccExampleWithReplace(t, "resources/grafana_machine_learning_alert/resource.tf", map[string]string{
+					"Test Job":   randomJobName,
+					"Test Alert": randomAlertName,
+					"\"any\"":    "\"low\"",
+				}),
+				Check: resource.ComposeTestCheckFunc(
+					testAccMLJobCheckExists("grafana_machine_learning_job.test_alert_job", &job),
+					testAccMLJobAlertCheckExists("grafana_machine_learning_alert.test_job_alert", &job, &alert),
+					resource.TestCheckResourceAttrSet("grafana_machine_learning_alert.test_job_alert", "id"),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_job_alert", "title", randomAlertName),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_job_alert", "anomaly_condition", "low"),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_job_alert", "threshold", ">0.8"),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_job_alert", "window", "15m"),
 				),
 			},
 			{
@@ -54,8 +76,8 @@ func TestAccResourceJobAlert(t *testing.T) {
 func TestAccResourceOutlierAlert(t *testing.T) {
 	testutils.CheckCloudInstanceTestsEnabled(t)
 
-	randomOutlierName := acctest.RandomWithPrefix("Test Job")
-	randomAlertName := acctest.RandomWithPrefix("Test Outlier Alert")
+	randomOutlierName := acctest.RandomWithPrefix("Test Outlier")
+	randomAlertName := acctest.RandomWithPrefix("Test Alert")
 
 	var outlier mlapi.OutlierDetector
 	var alert mlapi.Alert
@@ -74,6 +96,22 @@ func TestAccResourceOutlierAlert(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccMLOutlierCheckExists("grafana_machine_learning_outlier_detector.test_alert_outlier_detector", &outlier),
 					testAccMLOutlierAlertCheckExists("grafana_machine_learning_alert.test_outlier_alert", &outlier, &alert),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_outlier_alert", "title", randomAlertName),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_outlier_alert", "window", "1h"),
+				),
+			},
+			// Test updating the window.
+			{
+				Config: testutils.TestAccExampleWithReplace(t, "resources/grafana_machine_learning_alert/outlier_alert.tf", map[string]string{
+					"Test Outlier": randomOutlierName,
+					"Test Alert":   randomAlertName,
+					"\"1h\"":       "\"30m\"",
+				}),
+				Check: resource.ComposeTestCheckFunc(
+					testAccMLOutlierCheckExists("grafana_machine_learning_outlier_detector.test_alert_outlier_detector", &outlier),
+					testAccMLOutlierAlertCheckExists("grafana_machine_learning_alert.test_outlier_alert", &outlier, &alert),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_outlier_alert", "title", randomAlertName),
+					resource.TestCheckResourceAttr("grafana_machine_learning_alert.test_outlier_alert", "window", "30m"),
 				),
 			},
 			{