Skip to content

Commit 70e344b

Browse files
authored
Update pdc scope (#2012)
1 parent f572d44 commit 70e344b

3 files changed

+6
-4
lines changed

internal/resources/cloud/data_source_private_data_source_connect_network.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@ func (r *PDCNetworksDataSource) Read(ctx context.Context, req datasource.ReadReq
118118
if data.NameFilter.ValueString() != "" && data.NameFilter.ValueString() != policy.Name {
119119
continue
120120
}
121-
if !slices.Contains(policy.Scopes, "pdc-signing:write") {
121+
// Include pdc-signing:write to account for old PDC access policies
122+
if !slices.Contains(policy.Scopes, "pdc-signing:write") || !slices.Contains(policy.Scopes, "set:pdc-signing") {
122123
continue
123124
}
124125
data.PrivateDataSourceNetworks = append(data.PrivateDataSourceNetworks, PDCNetworksDataSourcePolicyModel{

internal/resources/cloud/resource_private_data_source_connect_network.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,8 @@ func listPDCNetworkIds(ctx context.Context, client *gcom.APIClient, data *Lister
124124
}
125125

126126
for _, policy := range resp.Items {
127-
if slices.Contains(policy.Scopes, "pdc-signing:write") {
127+
// Include pdc-signing:write to account for old PDC access policies
128+
if slices.Contains(policy.Scopes, "pdc-signing:write") || slices.Contains(policy.Scopes, "set:pdc-signing") {
128129
policies = append(policies, resourceAccessPolicyID.Make(regionSlug, policy.Id))
129130
}
130131
}
@@ -145,7 +146,7 @@ func createPDCNetwork(ctx context.Context, d *schema.ResourceData, client *gcom.
145146
PostAccessPoliciesRequest(gcom.PostAccessPoliciesRequest{
146147
Name: d.Get("name").(string),
147148
DisplayName: &displayName,
148-
Scopes: []string{"pdc-signing:write"},
149+
Scopes: []string{"set:pdc-signing"},
149150
Realms: []gcom.PostAccessPoliciesRequestRealmsInner{{Type: "stack", Identifier: d.Get("stack_identifier").(string)}},
150151
})
151152
result, _, err := req.Execute()

internal/resources/cloud/resource_private_data_source_connect_network_token_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func TestResourcePrivateDataSourceConnectNetworkToken_Basic(t *testing.T) {
4040
resource.TestCheckResourceAttr("grafana_cloud_access_policy.test", "name", initialName),
4141
resource.TestCheckResourceAttr("grafana_cloud_access_policy.test", "display_name", initialName),
4242
resource.TestCheckResourceAttr("grafana_cloud_access_policy.test", "scopes.#", "1"),
43-
resource.TestCheckResourceAttr("grafana_cloud_access_policy.test", "scopes.0", "pdc-signing:write"),
43+
resource.TestCheckResourceAttr("grafana_cloud_access_policy.test", "scopes.0", "set:pdc-signing"),
4444
resource.TestCheckResourceAttr("grafana_cloud_access_policy.test", "realm.#", "1"),
4545
resource.TestCheckResourceAttr("grafana_cloud_access_policy.test", "realm.0.type", "stack"),
4646

0 commit comments

Comments
 (0)