You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Update dependency org.javassist:javassist to v3.29.2-GA
* Update dependency org.slf4j:slf4j-api to v2.0.1
* Update dependency org.apache.logging.log4j:log4j-api to v2.19.0
* Update dependency org.apache.logging.log4j:log4j-core to v2.19.0
* Update dependency ch.qos.logback:logback-classic to v1.4.1
* [pom] Update project build output timestamp for reproducible builds
* [ci] Correct spelling mistake in proxy factory in better way to avoid naming conflict
Alternative attempt to mybatis#2692
* [maven-release-plugin] prepare release mybatis-3.5.11
* [maven-release-plugin] prepare for next development iteration
* Update dependency org.slf4j:slf4j-api to v2.0.2
* Update junit5 monorepo to v5.9.1
* Referencing collection parameter by name fails
... when the first argument is a special one (i.e. `RowBounds` or `ResultHandler`).
fixesmybatis#2693
* Update dependency org.slf4j:slf4j-api to v2.0.3
* Update dependency org.testcontainers:junit-jupiter to v1.17.4
* Update dependency org.testcontainers:mysql to v1.17.4
* Update dependency org.testcontainers:postgresql to v1.17.4
* Fix a race condition caused by other threads calling mapper methods while mappedStatements are being constructed
* Update dependency ch.qos.logback:logback-classic to v1.4.2
* Update dependency ch.qos.logback:logback-classic to v1.4.3
* Update dependency org.testcontainers:junit-jupiter to v1.17.5
* Update dependency org.testcontainers:mysql to v1.17.5
* Update dependency org.testcontainers:postgresql to v1.17.5
* Update dependency ch.qos.logback:logback-classic to v1.4.4
* Update dependency org.mockito:mockito-junit-jupiter to v4.8.1
* Update dependency mysql:mysql-connector-java to v8.0.31
* Update dependency org.mockito:mockito-core to v4.8.1
* Enable ability to provide custom configuration to XMLConfigBuilder
Supported via the InputStream/Reader constructors
Default constructors will keep using a new configuration
* A subclassed configuration class can now be passed to allow XMLConfigBuilder
to use a specific implementation when creating the configuration
* Adding mapper could fail under JPMS
Under JPMS, ClassLoader#getResources() throws `FileSystemException` it seems.
It might be better to catch IOException, but it could swallow some exception that should be thrown.
Should fixmybatis#2598
* Update mockito monorepo to v4.9.0
* Update dependency org.testcontainers:junit-jupiter to v1.17.6
* Update dependency org.testcontainers:mysql to v1.17.6
* Update dependency org.testcontainers:postgresql to v1.17.6
* Update dependency org.slf4j:slf4j-api to v2.0.4
* Update dependency ch.qos.logback:logback-classic to v1.4.5
* Minor correction: boolean can never be null
* Added failing tests
Some DBs support INSERT, UPDATE or DELETE statement that returns result set.
PostgreSQL has RETURNING
MS SQL Server has OUTPUT
MyBatis can return results by using @select, @SelectProvider or <select />, however, rollback does not work as expected because SELECT does not mark the session 'dirty'.
* Added 'affectData' attribute to SELECT statements
To indicate the SELECT affects DB data.
e.g. PostgreSQL's RETURNING, MS SQL Server's OUTPUT
* Update dependency ch.qos.reload4j:reload4j to v1.2.23
* Bump postgresql from 42.5.0 to 42.5.1
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.5.0 to 42.5.1.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](pgjdbc/pgjdbc@REL42.5.0...REL42.5.1)
---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <[email protected]>
* Update dependency org.slf4j:slf4j-api to v2.0.5
* Documentation
* selectCursor() should respect affectData as well
* Update dependency ch.qos.reload4j:reload4j to v1.2.24
* Missing entry in es and ko doc [ci skip]
* Awful typo [ci skip]
* [pom] Update mysql-connector-j to new GAV relocation
* [ci] Use charset with filewriter
* [pom] Add filter to exclude MANIFEST.MF from uber jar from other jars (using ours)
clears warning and behaviour is the same.
* Update dependency org.slf4j:slf4j-api to v2.0.6
* Update mockito monorepo to v4.10.0
* Avoid false-negative
* Update mockito monorepo to v4.11.0
* Update dependency org.mybatis:mybatis-parent to v37
* Resolve resultType by namespace and id when not provide resultType and resultMap
* [actions] Drop jdk 18
* Minor refactoring, more tests
* Update dependency org.assertj:assertj-core to v3.24.1
* Update junit5 monorepo to v5.9.2
* Update mockito monorepo to v5
* Update dependency org.assertj:assertj-core to v3.24.2
* Update dependency com.mysql:mysql-connector-j to v8.0.32
* Update dependency maven to v3.8.7
* Include JDK 21 (EA at this point) in CI build
* [pom] Add mockito subclass support
some of our tests need the legacy style support that mockito made available. We should look at those in longer term to get on fact that inline is now the default as per mockito we will likely have other issues.
* Update mockito monorepo to v5.1.0
* Update mockito monorepo to v5.1.1
* Update dependency org.postgresql:postgresql to v42.5.2
* [ci] Type the array lists
* Update dependency org.postgresql:postgresql to v42.5.3
* [ci] Sort imports
* [ci] Run partial formatting
* [ci] Update copyright dates
* [ci] Remove extra /p as not required in the javadoc
* [ci] formatting
* [ci] Update copyright dates
* [ci] formatting
* [ci] Update copyright date
* [ci] formatting
* [ci] Formatting
* [ci] formatting
* [ci] formatting
* [ci] formatting
* [ci] formatting
* [ci] Add note about formatting to readme
* [ci] Try adjusting formatting on readme
* [pom] For pre jdk 16 skip impsort
* [ci] Fix readme for formatter tags
* [mvn] Bump to maven 3.9.0 and change maven.config to 3.9/4.x style
* Search readable property when resolving constructor arg type
Should fixmybatis#2803
* Update test code to clarify the consequence
* Update dependency org.postgresql:postgresql to v42.5.4
* Add Unit Test for PooledDataSource
* Using cursor causes OOM mybatis#2812
* [ci] Minor formatting adjustments
* [ci] Import sort new test class
* [ci] Fix end of line markers at end of file per git standards (ie empty last line)
* [ci] Apply open rewrite partially on java cleanup
* [ci] Add private constructors to classes that cannot be instantiated (all static)
* [test] Remove dumb test - not valid now as class is static and should not have been instantiated
* [test] Remove invalid extension of class for testing
* [ci] Tabs to spaces
* [ci] Add final where appropriate per open rewrite
relaxed some of its suggestions but generally took most.
* [pom] Move surefire configuration to parent and make properties more readable
* [pom] Update surefire property usage to non deprecated values
* [ci] Adjust argument
* [ci] Show active profiles being used
* [actions] Drop usage of ci only tests group as unnecessary / directly set excludedGroups
profile is not needed. All we are doing is setting a property.
* [actions] Run all tests for ubuntu jdk 11 using arglines
* [pom] Add comment on how to disable excluded groups runs
* [pom] Add another comment around excluded groups
* [ci] Add readme that describes how our testing works
* [ci] Do not use star imports (across test classes)
* [ci] Use diamond operators (test classes)
squash with diamond
* [ci] Add missing seial version uid at 1L (throughout tests)
* [ci] Use mockito argument matchers instead of deprecated logic
* [ci] Use 'L' instead of 'l' for long
* [ci] Remove new of primative as known
* [ci] Remove super as no super to call
* [ci] More direct returns to save on GC
* [ci] Various small items cleaning up assignments
* [ci] Better parsing wrapper classes
* [ci] Remove public from methods in interfaces
* [ci] Formatting / update copyright dates
* [ci] Add missing overrides
* [ci] Various small cleanups
* [ci] Use objects class for hash, equals usage
* [ci] Cleanup if statement breaks / return logic
* [ci] Remove unnecessary super calls
* [ci] Make static classes 'static'
* [ci] Remove unnecessary parentheses and allow quicker exit
* [ci] Add missing serial version uid as 1L
* [ci] Use diamond operator
* [ci] Remove named wrapper of list as type given already
* [ci] Remove unused variable from internal method
* [ci] Smarter list creation
* [ci] Update copyright dates
* [ci] Add back type as not until jdk 9 can this be determined
* Add resultOrdered="true" and change expected cursor's nestedResultObjects size to be less than 3
* Update dependency org.apache.logging.log4j:log4j-api to v2.20.0
* Update dependency org.apache.logging.log4j:log4j-core to v2.20.0
* Use CountDownLatch to coordinate the execution order
* [pom] Add some comments in the pom for clarity
* [pom] Remove compiler test compiler argument parameters as not needed now
* [maven-release-plugin] prepare release mybatis-3.5.12
* [maven-release-plugin] prepare for next development iteration
* [ci] Add release backup to gitignore
* [fix] Change formatter around javadoc to retain L&F and correct javadoc error
* [maven-release-plugin] prepare release mybatis-3.5.12
* [maven-release-plugin] prepare for next development iteration
* fix Chinese translation error for `parameterType`
---------
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jeremy Landis <[email protected]>
Co-authored-by: Iwao AVE! <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: tianshuang <[email protected]>
Co-authored-by: Willie Scholtz <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: FlyInWind <[email protected]>
Co-authored-by: hogimn <[email protected]>
Co-authored-by: gallyamb <[email protected]>
Co-authored-by: puppylpg <[email protected]>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+5-5
Original file line number
Diff line number
Diff line change
@@ -1,6 +1,6 @@
1
1
## If you have a question or need any help...
2
2
3
-
Please use [the mailing list](http://groups.google.com/group/mybatis-user) instead of creating issues on the tracker. Thank you!
3
+
Please use [the mailing list](https://groups.google.com/group/mybatis-user) instead of creating issues on the tracker. Thank you!
4
4
5
5
## Reporting a bug
6
6
@@ -9,13 +9,13 @@ Please use [the mailing list](http://groups.google.com/group/mybatis-user) inste
9
9
10
10
## Proposing a new feature
11
11
12
-
- It is a good idea to discuss your changes on [the mailing list](http://groups.google.com/group/mybatis-user) to get feedback from the community.
12
+
- It is a good idea to discuss your changes on [the mailing list](https://groups.google.com/group/mybatis-user) to get feedback from the community.
13
13
- If you have a patch with unit tests, send a pull request. Please see the [Contributing code](CONTRIBUTING.md#contributing-code) section.
14
14
15
15
16
16
## Improving documentation
17
17
18
-
- Documentations are placed under [src/site](https://github.com/mybatis/mybatis-3/tree/master/src/site) directory in [the xdoc format](http://maven.apache.org/doxia/references/xdoc-format.html), so it is basically the same as creating a patch to contribute documentation changes. Please see the [Contributing code](CONTRIBUTING.md#contributing-code) section.
18
+
- Documentations are placed under [src/site](https://github.com/mybatis/mybatis-3/tree/master/src/site) directory in [the xdoc format](https://maven.apache.org/doxia/references/xdoc-format.html), so it is basically the same as creating a patch to contribute documentation changes. Please see the [Contributing code](CONTRIBUTING.md#contributing-code) section.
19
19
20
20
## Contributing code
21
21
@@ -34,7 +34,7 @@ Please use [the mailing list](http://groups.google.com/group/mybatis-user) inste
34
34
* you may not use this file except in compliance with the License.
35
35
* You may obtain a copy of the License at
36
36
*
37
-
* http://www.apache.org/licenses/LICENSE-2.0
37
+
* https://www.apache.org/licenses/LICENSE-2.0
38
38
*
39
39
* Unless required by applicable law or agreed to in writing, software
40
40
* distributed under the License is distributed on an "AS IS" BASIS,
@@ -57,6 +57,6 @@ Here are the steps of a typical workflow.
57
57
6. Send a [pull request](https://help.github.com/articles/using-pull-requests).
58
58
59
59
For steps 1 to 3, please read [this GitHub help](https://help.github.com/articles/fork-a-repo) if you are not familiar with these operations.
60
-
Step 4 and 5 are basic [git](http://git-scm.com/) operations. Please see the [online documentation](http://git-scm.com/documentation) for its usage.
60
+
Step 4 and 5 are basic [git](https://git-scm.com/) operations. Please see the [online documentation](https://git-scm.com/documentation) for its usage.
61
61
62
62
For how to write a unit test, please see the [unit test](https://github.com/mybatis/mybatis-3/wiki/Unit-Test) page.
Please use the mailing list. http://groups.google.com/group/mybatis-user
11
+
Please use the mailing list. https://groups.google.com/group/mybatis-user
12
12
Or Stack Overflow with 'mybatis' tag. https://stackoverflow.com/questions/ask?tags=mybatis
13
13
Questions on this tracker will be closed without comment.
14
14
@@ -26,7 +26,7 @@ And we spend a lot of time just trying to reproduce the reported problem, so ple
26
26
Feature request?
27
27
=======================
28
28
- Please delete the BUG REPORT FORM below and describe the feature.
29
-
- It is a good idea to discuss your changes on the mailing list to get feedback from the community. http://groups.google.com/group/mybatis-user
29
+
- It is a good idea to discuss your changes on the mailing list to get feedback from the community. https://groups.google.com/group/mybatis-user
30
30
- If you have a patch with unit tests, send a pull request. Please see the wiki page : https://github.com/mybatis/mybatis-3/wiki/Contribute
Mybatis-core is now being auto formatted. Given nature of some code logic with mybatis, it is more appropriate to force a formatting structure manually for snippets such as sql statements. To do so, add following blocks around code.
29
+
30
+
-```// @formatter:off``` to start the block of unformatted code
31
+
-```// @formatter:on``` to end the block of unformatted code
32
+
33
+
If comment sections need same behaviour such as javadocs, note that the entire block must be around entire comment as direct usage does not properly indicate that formatter treats it all as one comment block regardless.
34
+
35
+
Tests
36
+
-----
37
+
38
+
Mybatis-3 code runs more expressive testing depending on jdk usage and platform.
39
+
40
+
By default, we set ```<excludedGroups>TestcontainersTests</excludedGroups>``` which will exclude a subset of tests with @Tag('TestcontainersTests'). Further, if pre jdk 16, we will further exclude record classes from executions further reducing tests.
41
+
42
+
When using jdk 16+, we adjust the rule to ```<excludedGroups>TestcontainersTests,RequireIllegalAccess</excludedGroups>```.
43
+
44
+
When we run on ci platform, we further make adjustments as needed. See [here](.github/workflows/ci.yaml) for details.
45
+
46
+
As of 2/20/2023, using combined system + jdk will result in given number of tests ran. This will change as tests are added or removed over time.
47
+
48
+
without adjusting settings (ie use as is, platform does not matter)
49
+
50
+
- any OS + jdk 11 = 1730 tests
51
+
- any OS + jdk 17 = 1710 tests
52
+
- any OS + jdk 19 = 1710 tests
53
+
- any OS + jdk 20 = 1710 tests
54
+
- any OS + jdk 21 = 1710 tests
55
+
56
+
our adjustments for GH actions where platform does matter
0 commit comments