Skip to content

@graphql-eslint/fields-on-correct-type vscode highlight #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tonytoth opened this issue Dec 7, 2021 · 3 comments · Fixed by #837
Closed

@graphql-eslint/fields-on-correct-type vscode highlight #825

tonytoth opened this issue Dec 7, 2021 · 3 comments · Fixed by #837
Labels
kind/enhancement New feature or request stage/5-alpha-release-testing The pull request is merged, an alpha release is available, to be tested

Comments

@tonytoth
Copy link

tonytoth commented Dec 7, 2021

Describe the bug
The wrong field is not highlighted the right way in VSCode. As you can see it is working fine in "Problems" tab but the hightlight is not working as expected.

To Reproduce
Steps to reproduce the behavior:
Screenshot 2021-12-07 at 09 29 05

Expected behavior
It should highlight the whole line / word.

Environment:

  • OS: Ubuntu
  • @graphql-eslint/eslint-plugin": "^3.0.1
  • NodeJS: v12.18.3

Additional context
@dimaMachina
Copy link
Contributor

we use graphql-js rule that unfortunately report only start position of line and column, I asked this question in their repo graphql/graphql-js#3415 if it's possible I'll fix this

@dimaMachina dimaMachina added the kind/enhancement New feature or request label Dec 9, 2021
@dimaMachina dimaMachina mentioned this issue Dec 11, 2021
Merged
@dimaMachina dimaMachina added the stage/5-alpha-release-testing The pull request is merged, an alpha release is available, to be tested label Dec 11, 2021
@dimaMachina
Copy link
Contributor

Found a workaround to fix this for all graphql-js rules, this will be fixed on the next graphql-eslint version.

@dotansimha
Copy link
Member

Fixed in @graphql-eslint/[email protected]. Thanks @B2o5T ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request stage/5-alpha-release-testing The pull request is merged, an alpha release is available, to be tested
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix error report location for graphql-js rules graphql-hive/graphql-eslint
3 participants
@dotansimha @dimaMachina @tonytoth