Improve Fastify integration (#3930)

* Improve Fastify integration

* Go

* Fix tests

Author: ardatan

.changeset/neat-goats-see.md

@@ -0,0 +1,10 @@
+---
+'@graphql-yoga/apollo-managed-federation': patch
+'@graphql-yoga/plugin-apollo-inline-trace': patch
+'@graphql-yoga/plugin-defer-stream': patch
+'@graphql-yoga/plugin-jwt': patch
+'graphql-yoga': patch
+'@graphql-yoga/subscription': patch
+---
+
+Bump `@whatwg-node/server`

examples/fastify/src/app.ts

@@ -118,21 +118,11 @@ export function buildApp(logging = true) {
   app.route({
     url: graphQLServer.graphqlEndpoint,
     method: ['GET', 'POST', 'OPTIONS'],
-    handler: async (req, reply) => {
-      const response = await graphQLServer.handleNodeRequestAndResponse(req, reply, {
+    handler: (req, reply) =>
+      graphQLServer.handleNodeRequestAndResponse(req, reply, {
         req,
         reply,
-      });
-      for (const [name, value] of response.headers) {
-        reply.header(name, value);
-      }
-
-      reply.status(response.status);
-
-      reply.send(response.body);
-
-      return reply;
-    },
+      }),
   });
 
   return [app, graphQLServer.graphqlEndpoint] as const;

jest.config.js

@@ -45,6 +45,7 @@ if (process.env.LEAKS_TEST === 'true') {
 testMatch.push('!**/dist/**', '!**/.bob/**');
 
 module.exports = {
+  prettierPath: null,
   testEnvironment: 'node',
   rootDir: ROOT_DIR,
   restoreMocks: true,

packages/graphql-yoga/package.json

@@ -58,7 +58,7 @@
     "@graphql-yoga/subscription": "workspace:^",
     "@whatwg-node/fetch": "^0.10.5",
     "@whatwg-node/promise-helpers": "^1.2.4",
-    "@whatwg-node/server": "^0.10.1",
+    "@whatwg-node/server": "^0.10.2",
     "dset": "^3.1.4",
     "lru-cache": "^10.0.0",
     "tslib": "^2.8.1"

packages/plugins/apollo-inline-trace/package.json

@@ -52,7 +52,7 @@
     "@graphql-tools/delegate": "^10.1.1",
     "@graphql-tools/federation": "^3.0.0",
     "@whatwg-node/fetch": "^0.10.1",
-    "@whatwg-node/server": "^0.10.1",
+    "@whatwg-node/server": "^0.10.2",
     "graphql": "16.10.0",
     "graphql-yoga": "workspace:*"
   },

packages/plugins/apollo-managed-federation/package.json

@@ -56,7 +56,7 @@
   },
   "devDependencies": {
     "@whatwg-node/fetch": "^0.10.1",
-    "@whatwg-node/server": "^0.10.1",
+    "@whatwg-node/server": "^0.10.2",
     "graphql": "16.10.0",
     "graphql-yoga": "workspace:^",
     "typescript": "5.8.2"

packages/plugins/defer-stream/__tests__/defer-stream.spec.ts

@@ -149,9 +149,14 @@ Content-Length: 44
 {"data":{"stream":["A","B"]},"hasNext":true}
 ---
 Content-Type: application/json; charset=utf-8
-Content-Length: 69
+Content-Length: 68
 
-{"incremental":[{"items":["C"],"path":["stream",2]}],"hasNext":false}
+{"incremental":[{"items":["C"],"path":["stream",2]}],"hasNext":true}
+---
+Content-Type: application/json; charset=utf-8
+Content-Length: 17
+
+{"hasNext":false}
 -----
 "
 `);

packages/plugins/defer-stream/package.json

@@ -46,7 +46,7 @@
   "devDependencies": {
     "@graphql-tools/executor-http": "^1.1.9",
     "@whatwg-node/fetch": "^0.10.1",
-    "@whatwg-node/server": "^0.10.1",
+    "@whatwg-node/server": "^0.10.2",
     "fetch-multipart-graphql": "3.2.2",
     "graphql": "16.10.0",
     "graphql-yoga": "workspace:*",

packages/plugins/jwt/src/plugin.ts

@@ -29,6 +29,22 @@ export function useJWT(options: JwtPluginOptions): Plugin<{
   const payloadByContext = new WeakMap<object, PluginPayload>();
   const payloadByRequest = new WeakMap<Request, PluginPayload>();
   const validatedRequestAndContextSet = new WeakSet<object>();
+
+  function handleError(e: unknown) {
+    // User-facing errors should be handled based on the configuration.
+    // These errors are handled based on the value of "reject.invalidToken" config.
+    if (e instanceof GraphQLError) {
+      if (normalizedOptions.reject.invalidToken) {
+        throw e;
+      }
+
+      return null;
+    }
+
+    // Server/internal errors should be thrown, so they can be handled by the error handler and be masked.
+    throw e;
+  }
+
   const lookupToken = (payload: ExtractTokenFunctionParams) => {
     const iterator = normalizedOptions.tokenLookupLocations[Symbol.iterator]();
     function iterate(): MaybePromise<{
@@ -50,6 +66,7 @@ export function useJWT(options: JwtPluginOptions): Plugin<{
           }
           return iterate();
         },
+        handleError,
       );
     }
     return iterate();
@@ -82,21 +99,6 @@ export function useJWT(options: JwtPluginOptions): Plugin<{
     return iterate();
   };
 
-  function handleError(e: unknown) {
-    // User-facing errors should be handled based on the configuration.
-    // These errors are handled based on the value of "reject.invalidToken" config.
-    if (e instanceof GraphQLError) {
-      if (normalizedOptions.reject.invalidToken) {
-        throw e;
-      }
-
-      return;
-    }
-
-    // Server/internal errors should be thrown, so they can be handled by the error handler and be masked.
-    throw e;
-  }
-
   const lookupAndValidate = (payload: ExtractTokenFunctionParams) => {
     // Mark the context and request as validated, so we don't process them again.
     if (payload.serverContext) {
@@ -132,15 +134,20 @@ export function useJWT(options: JwtPluginOptions): Plugin<{
           decodedToken = jsonwebtoken.decode(lookupResult.token, { complete: true });
         } catch (e) {
           logger.warn(`Failed to decode JWT authentication token: `, e);
-          throw badRequestError(`Invalid authentication token provided`);
+          if (normalizedOptions.reject.invalidToken) {
+            throw badRequestError(`Invalid authentication token provided`);
+          }
+          return null;
         }
 
         if (!decodedToken) {
           logger.warn(
             `Failed to extract payload from incoming token, please make sure the token is a valid JWT.`,
           );
-
-          throw badRequestError(`Invalid authentication token provided`);
+          if (normalizedOptions.reject.invalidToken) {
+            throw badRequestError(`Invalid authentication token provided`);
+          }
+          return null;
         }
 
         // Fetch the signing key based on the key id.

packages/subscription/package.json

@@ -65,7 +65,7 @@
   "devDependencies": {
     "@graphql-yoga/redis-event-target": "workspace:*",
     "@types/ioredis-mock": "8.2.5",
-    "@whatwg-node/server": "^0.10.1",
+    "@whatwg-node/server": "^0.10.2",
     "ioredis-mock": "8.9.0"
   },
   "publishConfig": {