Skip to content

Update the conda package in conda-forge #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
motybz opened this issue Mar 20, 2022 · 13 comments
Closed

Update the conda package in conda-forge #309

motybz opened this issue Mar 20, 2022 · 13 comments
Labels
type: chore Changes to the build process or auxiliary tools and libraries such as documentation generation

Comments

@motybz
Copy link

motybz commented Mar 20, 2022

It seems that the latest conda package of gql is 2.0.0
https://anaconda.org/conda-forge/gql/files
Can you please upload the latest one? (3.1.0)
Can you please add it to the release automation?

@bollwyvl
Copy link
Contributor

There is already a (failing) automated PR for this: conda-forge/gql-feedstock#10

I'll see if i can get it cleaned up and merged.

@leszekhanusz leszekhanusz added the type: chore Changes to the build process or auxiliary tools and libraries such as documentation generation label Mar 27, 2022
@leszekhanusz
Copy link
Collaborator

All the conda stuff was made before I became maintainer. I suppose I'll need some access code or something. I'll see with the previous guys to see how we can proceed.

@motybz
Copy link
Author

motybz commented Mar 27, 2022

Thank you guys, please let me know if there is anything that I could help with.

@leszekhanusz
Copy link
Collaborator

Pinging @KingDarBoja

@bollwyvl
Copy link
Contributor

how we can proceed.

I'll be following up on the conda-forge side once a release goes out with #311 in it. I'll ensure that it runs pip check and the test suite under coverage with a threshold, which is usually good enough for enable automerge.

when i get that working, I can ping you: it's always good to have upstream-aware maintainers around! you'd just need to comment that you'd like to be a maintainer, and get added to a file.

if the existing maintainers are unresponsive (life happens), we can escalate to the conda-forge core team, but hopefully it doesn't come to that.

After a PR gets merged adding you as a maintainer, the workload would be:

  • wait for a notification about a bot making a PR after a pypi release
    • if it's auto-merge, and everyhting's green, then there's nothing to do
  • if dependencies changed or tests failed
    • change a few lines of yaml
    • type a comment on a PR
  • repeat until ✔️
  • press a button on PR

@bollwyvl
Copy link
Contributor

#311 is now in, so when the next release goes out, i'll work on overhauling the conda-forge build.

@leszekhanusz
Copy link
Collaborator

Version 3.2.0 is now released.

@bollwyvl
Copy link
Contributor

Thanks for the heads-up, I've started the PR over there:

conda-forge/gql-feedstock#12

If you'd like to help maintain (usually just means pressing button, maybe updating a dep or two), I can add you as well: just make a comment over there to that effect.

@bollwyvl
Copy link
Contributor

That PR was merged, and should be available within an hour or two on CDN: feel free to open another issue to propose another maintainer.

@leszekhanusz
Copy link
Collaborator

Great!

@motybz
Copy link
Author

motybz commented Apr 20, 2022

Thank you very much, it works.
I think it is worth writing in the documentation that extra dependencies not included in the conda package installation recipe (like websocket)

@bollwyvl
Copy link
Contributor

bollwyvl commented Apr 20, 2022 via email

@leszekhanusz
Copy link
Collaborator

I added some documentation on PR #321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Changes to the build process or auxiliary tools and libraries such as documentation generation
Projects
None yet
Development

No branches or pull requests

3 participants