Skip to content

Commit 9c5bca6

Browse files
committed
Remove unused show_graphiql kwarg
1 parent 1692349 commit 9c5bca6

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

Diff for: graphene_django/views.py

+8-14
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ def dispatch(self, request, *args, **kwargs):
186186
or 200
187187
)
188188
else:
189-
result, status_code = self.get_response(request, data, show_graphiql)
189+
result, status_code = self.get_response(request, data)
190190

191191
return HttpResponse(
192192
status=status_code, content=result, content_type="application/json"
@@ -200,11 +200,11 @@ def dispatch(self, request, *args, **kwargs):
200200
)
201201
return response
202202

203-
def get_response(self, request, data, show_graphiql=False):
203+
def get_response(self, request, data):
204204
query, variables, operation_name, id = self.get_graphql_params(request, data)
205205

206206
execution_result = self.execute_graphql_request(
207-
request, data, query, variables, operation_name, show_graphiql
207+
request, data, query, variables, operation_name
208208
)
209209

210210
if getattr(request, MUTATION_ERRORS_FLAG, False) is True:
@@ -231,7 +231,7 @@ def get_response(self, request, data, show_graphiql=False):
231231
response["id"] = id
232232
response["status"] = status_code
233233

234-
result = self.json_encode(request, response, pretty=show_graphiql)
234+
result = self.json_encode(request, response)
235235
else:
236236
result = None
237237

@@ -286,12 +286,8 @@ def parse_body(self, request):
286286

287287
return {}
288288

289-
def execute_graphql_request(
290-
self, request, data, query, variables, operation_name, show_graphiql=False
291-
):
289+
def execute_graphql_request(self, request, data, query, variables, operation_name):
292290
if not query:
293-
if show_graphiql:
294-
return None
295291
raise HttpError(HttpResponseBadRequest("Must provide query string."))
296292

297293
try:
@@ -324,14 +320,12 @@ def execute_graphql_request(
324320
request.method.lower() == "get"
325321
and operation_ast.operation != OperationType.QUERY
326322
):
327-
if show_graphiql:
328-
return None
329-
330323
raise HttpError(
331324
HttpResponseNotAllowed(
332325
["POST"],
333-
"Can only perform a {} operation from a POST request.".format(
334-
operation_ast.operation.value
326+
(
327+
f"Can only perform a {operation_ast.operation.value} operation "
328+
"from a POST request."
335329
),
336330
)
337331
)

0 commit comments

Comments
 (0)