Skip to content

Commit 108871d

Browse files
committed
fix test
fix tests
1 parent 28249a8 commit 108871d

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

Diff for: graphene_sqlalchemy/tests/test_batching.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,13 @@ def resolve_reporters(self, info):
637637
""", context_value={"session": session})
638638
messages = sqlalchemy_logging_handler.messages
639639

640-
select_statements = [message for message in messages if 'SELECT' in message and 'FROM articles' in message]
640+
if is_sqlalchemy_version_less_than('1.3'):
641+
# The batched SQL statement generated is different in 1.2.x
642+
# SQLAlchemy 1.3+ optimizes out a JOIN statement in `selectin`
643+
# See https://git.io/JewQu
644+
select_statements = [message for message in messages if 'SELECT' in message and 'JOIN articles' in message]
645+
else:
646+
select_statements = [message for message in messages if 'SELECT' in message and 'FROM articles' in message]
641647
assert len(select_statements) == 1
642648

643649

0 commit comments

Comments
 (0)