Skip to content

Simplify installation and add tests to examples #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #348
Cito opened this issue Mar 31, 2019 · 3 comments
Open
Tracked by #348

Simplify installation and add tests to examples #194

Cito opened this issue Mar 31, 2019 · 3 comments

Comments

@Cito
Copy link
Member

Cito commented Mar 31, 2019

We should replace requirements.txt with a Pipfile to make the installation of the examples even easier with Pipenv (the READMEs the should be adapted, too).

And we should add tests for the examples (e.g. running this default_query) that can be run with Travis so we notice when this breaks again, and that also demonstrate how the example servers can be consumed by a client.

@Nabellaleen
Copy link
Collaborator

Note: a lot of things are possible with setup.cfg and it's possible to automatically install packages when running virtualenv venv, base one the [Install] section.

So maybe we could also just use this "less opinionated" tool ?

(I love pipenv, but I feel, in the "current" conflict between pyproject.toml and setup.cfg, that this last one need a boost of popularity, so ... ;))

@Cito
Copy link
Member Author

Cito commented Mar 31, 2019

Actually pipenv uses neither setup.cfg nor pyproject.toml, but Pipfiles. The advantage of pipenv is that you don't need to explicitly setup a virtualenv, you just say pipenv install and then pipenv run app.py. For installing applications, like these example apps, Pipenv seems to be the right tool. But I'm not really up to date with Python packaging and find it all confusing.

@ProjectCheshire
Copy link
Member

ProjectCheshire commented Apr 1, 2019

@Cito I've loved pipenv. I use it for all my projects. One approach I've seen is also to dockerize examples. (that would probably be overkill for trivial examples)

I feel like pipenv is suited for instances and examples and setup / venv is more library packaging.

I'm possibly not completely up to date, either

@Nabellaleen Nabellaleen pinned this issue Apr 1, 2019
@erikwrede erikwrede mentioned this issue May 13, 2022
9 tasks
@erikwrede erikwrede unpinned this issue May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants