Skip to content

Commit be06750

Browse files
committed
Drop support for node14
Motivation: technically node14 end of life will happen in two months so we can still support it but it creates problems with #3791 Node14 doesn't support `AbortSignal` and since we want to allow resolvers to be canceled we need to expose this object through our public API (inside `info` argument). Potentialy this and all the other issues (e.g. how to test this feature on node14) can be worked around but complicates solution. So I think, it worth to deprecate node14 two months earlier in order to unblock #3791 especially since we still in alpha stage. Less critical but still significant problem with node14 is that it ships with npm6 which doesn't support default format of the lockfile used by npm9 and this make updating dependencies trickier.
1 parent 8313944 commit be06750

File tree

6 files changed

+11
-13642
lines changed

6 files changed

+11
-13642
lines changed

.eslintrc.cjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ module.exports = {
390390
'prefer-exponentiation-operator': 'error',
391391
'prefer-named-capture-group': 'off', // TODO: needs a better support in TS, see https://github.com/microsoft/TypeScript/issues/32098
392392
'prefer-numeric-literals': 'error',
393-
'prefer-object-has-own': 'off', // TODO: requires Node.js v16.9.0
393+
'prefer-object-has-own': 'error',
394394
'prefer-object-spread': 'error',
395395
'prefer-promise-reject-errors': 'error',
396396
'prefer-regex-literals': 'error',

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ jobs:
145145
runs-on: ubuntu-latest
146146
strategy:
147147
matrix:
148-
node_version_to_setup: [14, 16, 18]
148+
node_version_to_setup: [16, 18, 19]
149149
permissions:
150150
contents: read # for actions/checkout
151151
steps:

0 commit comments

Comments
 (0)