Skip to content

Commit e171a14

Browse files
Use replaceAll instead of RegExp with global flag (#3856)
1 parent 7e6844c commit e171a14

File tree

6 files changed

+8
-7
lines changed

6 files changed

+8
-7
lines changed

integrationTests/node/test.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ const graphqlPackageJSON = JSON.parse(
66
);
77

88
const nodeVersions = graphqlPackageJSON.engines.node
9+
.replaceAll('^', '')
10+
.replaceAll('>=', '')
911
.split(' || ')
10-
.map((version) => version.replace('^', '').replace('>=', ''))
1112
.sort((a, b) => b.localeCompare(a));
1213

1314
for (const version of nodeVersions) {

src/__testUtils__/dedent.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export function dedentString(string: string): string {
1212
indent += char;
1313
}
1414

15-
return trimmedStr.replace(RegExp('^' + indent, 'mg'), ''); // remove indent
15+
return trimmedStr.replaceAll(RegExp('^' + indent, 'mg'), ''); // remove indent
1616
}
1717

1818
/**

src/__testUtils__/inspectStr.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ export function inspectStr(str: Maybe<string>): string {
99
}
1010
return JSON.stringify(str)
1111
.replace(/^"|"$/g, '`')
12-
.replace(/\\"/g, '"')
13-
.replace(/\\\\/g, '\\');
12+
.replaceAll('\\"', '"')
13+
.replaceAll('\\\\', '\\');
1414
}

src/language/blockString.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ export function printBlockString(
122122
value: string,
123123
options?: { minimize?: boolean },
124124
): string {
125-
const escapedValue = value.replace(/"""/g, '\\"""');
125+
const escapedValue = value.replaceAll('"""', '\\"""');
126126

127127
// Expand a block string's raw value into independent lines.
128128
const lines = escapedValue.split(/\r\n|[\n\r]/g);

src/language/printer.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ function wrap(
370370
}
371371

372372
function indent(str: string): string {
373-
return wrap(' ', str.replace(/\n/g, '\n '));
373+
return wrap(' ', str.replaceAll('\n', '\n '));
374374
}
375375

376376
function hasMultilineItems(maybeArray: Maybe<ReadonlyArray<string>>): boolean {

src/utilities/printSchema.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -317,5 +317,5 @@ function printDescription(
317317
const prefix =
318318
indentation && !firstInBlock ? '\n' + indentation : indentation;
319319

320-
return prefix + blockString.replace(/\n/g, '\n' + indentation) + '\n';
320+
return prefix + blockString.replaceAll('\n', '\n' + indentation) + '\n';
321321
}

0 commit comments

Comments
 (0)