Enable 'new-cap' ESLint rule (#2762)

Author: IvanGoncharov

.eslintrc.yml

@@ -313,7 +313,7 @@ rules:
   max-statements: off
   max-statements-per-line: off
   multiline-comment-style: off
-  new-cap: off # TODO
+  new-cap: error
   no-array-constructor: error
   no-bitwise: off
   no-continue: off

resources/benchmark.js

@@ -17,7 +17,7 @@ const maxTime = 5;
 // The minimum sample size required to perform statistical analysis.
 const minSamples = 5;
 
-function LOCAL_DIR(...paths) {
+function localDir(...paths) {
   return path.join(__dirname, '..', ...paths);
 }
 
@@ -27,7 +27,7 @@ function prepareRevision(revision) {
   console.log(`🍳  Preparing ${revision}...`);
 
   if (revision === LOCAL) {
-    return babelBuild(LOCAL_DIR());
+    return babelBuild(localDir());
   }
 
   // Returns the complete git hash for a given git revision reference.
@@ -40,12 +40,12 @@ function prepareRevision(revision) {
   exec(`git archive "${hash}" | tar -xC "${dir}"`);
   exec('npm ci', { cwd: dir });
 
-  for (const file of findFiles(LOCAL_DIR('src'), '*/__tests__/*')) {
-    const from = LOCAL_DIR('src', file);
+  for (const file of findFiles(localDir('src'), '*/__tests__/*')) {
+    const from = localDir('src', file);
     const to = path.join(dir, 'src', file);
     fs.copyFileSync(from, to);
   }
-  exec(`cp -R "${LOCAL_DIR()}/src/__fixtures__/" "${dir}/src/__fixtures__/"`);
+  exec(`cp -R "${localDir()}/src/__fixtures__/" "${dir}/src/__fixtures__/"`);
 
   return babelBuild(dir);
 }
@@ -259,7 +259,7 @@ async function prepareAndRunBenchmarks(benchmarkPatterns, revisions) {
 
 // Find all benchmark tests to be run.
 function matchBenchmarks(patterns) {
-  let benchmarks = findFiles(LOCAL_DIR('src'), '*/__tests__/*-benchmark.js');
+  let benchmarks = findFiles(localDir('src'), '*/__tests__/*-benchmark.js');
   if (patterns.length > 0) {
     benchmarks = benchmarks.filter((benchmark) =>
       patterns.some((pattern) => path.join('src', benchmark).includes(pattern)),

src/utilities/__tests__/coerceInputValue-test.js

@@ -260,7 +260,7 @@ describe('coerceInputValue', () => {
   });
 
   describe('for GraphQLInputObject with default value', () => {
-    const TestInputObject = (defaultValue) =>
+    const makeTestInputObject = (defaultValue) =>
       new GraphQLInputObjectType({
         name: 'TestInputObject',
         fields: {
@@ -272,22 +272,22 @@ describe('coerceInputValue', () => {
       });
 
     it('returns no errors for valid input value', () => {
-      const result = coerceValue({ foo: 5 }, TestInputObject(7));
+      const result = coerceValue({ foo: 5 }, makeTestInputObject(7));
       expectValue(result).to.deep.equal({ foo: 5 });
     });
 
     it('returns object with default value', () => {
-      const result = coerceValue({}, TestInputObject(7));
+      const result = coerceValue({}, makeTestInputObject(7));
       expectValue(result).to.deep.equal({ foo: 7 });
     });
 
     it('returns null as value', () => {
-      const result = coerceValue({}, TestInputObject(null));
+      const result = coerceValue({}, makeTestInputObject(null));
       expectValue(result).to.deep.equal({ foo: null });
     });
 
     it('returns NaN as value', () => {
-      const result = coerceValue({}, TestInputObject(NaN));
+      const result = coerceValue({}, makeTestInputObject(NaN));
       expectValue(result).to.have.property('foo').that.satisfy(Number.isNaN);
     });
   });

src/validation/rules/KnownArgumentNamesRule.js

@@ -21,6 +21,7 @@ import type {
  */
 export function KnownArgumentNamesRule(context: ValidationContext): ASTVisitor {
   return {
+    // eslint-disable-next-line new-cap
     ...KnownArgumentNamesOnDirectivesRule(context),
     Argument(argNode) {
       const argDef = context.getArgument();

src/validation/rules/ProvidedRequiredArgumentsRule.js

@@ -25,6 +25,7 @@ export function ProvidedRequiredArgumentsRule(
   context: ValidationContext,
 ): ASTVisitor {
   return {
+    // eslint-disable-next-line new-cap
     ...ProvidedRequiredArgumentsOnDirectivesRule(context),
     Field: {
       // Validate on leave to allow for deeper errors to appear first.