Merge pull request #79 from dylanahsmith/optional-client-mutation-id

Remove non-null restriction on clientMutationId field definitions.

Author: wincent

src/__tests__/starWarsSchema.js

@@ -101,13 +101,13 @@ import {
  * }
  *
  * input IntroduceShipInput {
- *   clientMutationId: string!
+ *   clientMutationId: string
  *   shipName: string!
  *   factionId: ID!
  * }
  *
- * input IntroduceShipPayload {
- *   clientMutationId: string!
+ * type IntroduceShipPayload {
+ *   clientMutationId: string
  *   ship: Ship
  *   faction: Faction
  * }
@@ -244,13 +244,13 @@ var queryType = new GraphQLObjectType({
  *
  * It creates these two types implicitly:
  *   input IntroduceShipInput {
- *     clientMutationId: string!
+ *     clientMutationId: string
  *     shipName: string!
  *     factionId: ID!
  *   }
  *
- *   input IntroduceShipPayload {
- *     clientMutationId: string!
+ *   type IntroduceShipPayload {
+ *     clientMutationId: string
  *     ship: Ship
  *     faction: Faction
  *   }

src/mutation/__tests__/mutation.js

@@ -188,10 +188,6 @@ describe('mutationWithClientMutationId()', () => {
             type {
               name
               kind
-              ofType {
-                name
-                kind
-              }
             }
           }
         }
@@ -204,12 +200,8 @@ describe('mutationWithClientMutationId()', () => {
             {
               name: 'clientMutationId',
               type: {
-                name: null,
-                kind: 'NON_NULL',
-                ofType: {
-                  name: 'String',
-                  kind: 'SCALAR'
-                }
+                name: 'String',
+                kind: 'SCALAR'
               }
             }
           ]
@@ -229,10 +221,6 @@ describe('mutationWithClientMutationId()', () => {
             type {
               name
               kind
-              ofType {
-                name
-                kind
-              }
             }
           }
         }
@@ -247,18 +235,13 @@ describe('mutationWithClientMutationId()', () => {
               type: {
                 name: 'Int',
                 kind: 'SCALAR',
-                ofType: null
               }
             },
             {
               name: 'clientMutationId',
               type: {
-                name: null,
-                kind: 'NON_NULL',
-                ofType: {
-                  name: 'String',
-                  kind: 'SCALAR'
-                }
+                name: 'String',
+                kind: 'SCALAR'
               }
             }
           ]

src/mutation/mutation.js

@@ -62,13 +62,13 @@ export function mutationWithClientMutationId(
   var augmentedInputFields = () => ({
     ...resolveMaybeThunk(inputFields),
     clientMutationId: {
-      type: new GraphQLNonNull(GraphQLString)
+      type: GraphQLString
     }
   });
   var augmentedOutputFields = () => ({
     ...resolveMaybeThunk(outputFields),
     clientMutationId: {
-      type: new GraphQLNonNull(GraphQLString)
+      type: GraphQLString
     }
   });