Skip to content

[2020-10-01] Add validation rule to forbid introspection fields in the root of a GraphQL subscription #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
benjie opened this issue Nov 8, 2020 · 2 comments
Assignees
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.

Comments

@benjie
Copy link
Member

benjie commented Nov 8, 2020

__typename at the root of a subscription operation throws an error. It doesn't make sense to support it. It was agreed that since it already doesn't work, adding an explicit validation rule to forbid it would make sense and be "non-breaking".

Original PR here: graphql/graphql-spec#776

TODO:


Note: Action Item issues are reviewed and closed during Working Group
meetings.

@benjie benjie self-assigned this Nov 8, 2020
@benjie
Copy link
Member Author

benjie commented Nov 8, 2020

@IvanGoncharov Given GraphQL.js is in feature freeze; should I hold off on this PR to GraphQL.js?

@benjie benjie added the Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. label Nov 25, 2020
@benjie
Copy link
Member Author

benjie commented Nov 25, 2020

Spec PR updated, GraphQL.js PR filed.

@benjie benjie closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
None yet
Development

No branches or pull requests

1 participant