Skip to content

Add PluginPosition.None to quickly hide a plugin #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbolli opened this issue Jun 21, 2024 · 1 comment · May be fixed by #1469
Closed

Add PluginPosition.None to quickly hide a plugin #1456

mbolli opened this issue Jun 21, 2024 · 1 comment · May be fixed by #1469
Labels
wontfix This will not be worked on

Comments

@mbolli
Copy link

mbolli commented Jun 21, 2024

Is your feature request related to a problem? Please describe.

Showing a plugin conditionally is already possible with PluginManager.remove() and PluginManager.add().
However, it is even easier to set Plugin.position to a non-existing PluginPosition.
This works, but shows obviously a TypeScript warning TS2339: Property None does not exist on type typeof PluginPosition.

Describe the solution you'd like

To add PluginPosition.None to the Enum would not hurt anyone.

Describe alternatives you've considered

To ts-ignore my assignment line

Additional context

--

Copy link

stale bot commented Apr 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 26, 2025
@stale stale bot closed this as completed May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant