Skip to content

Commit 8bd6545

Browse files
committed
Attempt at expressing some todos
1 parent cc8a427 commit 8bd6545

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

GRDB/QueryInterface/SQLGeneration/SQLQueryGenerator.swift

+5
Original file line numberDiff line numberDiff line change
@@ -500,8 +500,13 @@ private struct SQLQualifiedRelation {
500500
// Filters and order are handled in a subquery (see target below).
501501
// We only keep children that need to be exposed in the outer
502502
// query (those with a non-empty selection).
503+
#warning("TODO outerRelation 1")
503504
// TODO: we may have a problem if we remove children used for
504505
// ordering or filtering with aliases.
506+
#warning("TODO outerRelation 2")
507+
// TODO: keep children that have children with selection
508+
#warning("TODO target")
509+
// TODO: in the target remove to-many children
505510
let outerRelation = child.relation
506511
.with(\.firstOnly, false)
507512
.unfiltered()

0 commit comments

Comments
 (0)