From b3ad3d8acde28394b51e8d4a1254ea8528849a2f Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 16 Dec 2024 14:40:20 +0100 Subject: [PATCH 1/9] Update health.yaml --- .github/workflows/health.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml index 9d32c209..fc7eb905 100644 --- a/.github/workflows/health.yaml +++ b/.github/workflows/health.yaml @@ -5,8 +5,8 @@ on: types: [opened, synchronize, reopened, labeled, unlabeled] jobs: health: - uses: dart-lang/ecosystem/.github/workflows/health.yaml@9fabe464ea1d8408774de74d2ac759c1f90ae480 + uses: dart-lang/ecosystem/.github/workflows/health.yaml@main with: - checks: "version,changelog,do-not-submit,breaking,coverage,leaking" + checks: "changelog,do-not-submit,breaking,coverage,leaking" permissions: - pull-requests: write \ No newline at end of file + pull-requests: write From 054b442e489a6ecad6527e55fde1b9da6d038fc7 Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 16 Dec 2024 14:46:37 +0100 Subject: [PATCH 2/9] Upgrade example --- example/grpc-web/pubspec.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/example/grpc-web/pubspec.yaml b/example/grpc-web/pubspec.yaml index e215c131..11d1725f 100644 --- a/example/grpc-web/pubspec.yaml +++ b/example/grpc-web/pubspec.yaml @@ -3,7 +3,7 @@ description: Dart gRPC-Web sample client publish_to: none environment: - sdk: '>=2.12.0 <3.0.0' + sdk: ^3.5.0 dependencies: grpc: @@ -11,6 +11,6 @@ dependencies: protobuf: ^3.0.0 dev_dependencies: - build_runner: ^2.0.0 - build_web_compilers: '>3.0.0 <5.0.0' - lints: ^2.0.0 + build_runner: ^2.4.13 + build_web_compilers: ^4.0.11 + lints: ^5.1.0 From a67456ac77616fb8971fabf881e32dfd1917304d Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 16 Dec 2024 14:50:36 +0100 Subject: [PATCH 3/9] Fixes --- .github/workflows/health.yaml | 1 + example/grpc-web/pubspec.yaml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml index fc7eb905..3ba41f30 100644 --- a/.github/workflows/health.yaml +++ b/.github/workflows/health.yaml @@ -8,5 +8,6 @@ jobs: uses: dart-lang/ecosystem/.github/workflows/health.yaml@main with: checks: "changelog,do-not-submit,breaking,coverage,leaking" + ignore_coverage: "example/**,interop/**" permissions: pull-requests: write diff --git a/example/grpc-web/pubspec.yaml b/example/grpc-web/pubspec.yaml index 11d1725f..10f80ceb 100644 --- a/example/grpc-web/pubspec.yaml +++ b/example/grpc-web/pubspec.yaml @@ -13,4 +13,4 @@ dependencies: dev_dependencies: build_runner: ^2.4.13 build_web_compilers: ^4.0.11 - lints: ^5.1.0 + lints: ^5.0.0 From 5d737789839c7333ed00d42ff0c6fe5ae3bfa72a Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 16 Dec 2024 14:54:57 +0100 Subject: [PATCH 4/9] try different syntax --- .github/workflows/health.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml index 3ba41f30..1836a72f 100644 --- a/.github/workflows/health.yaml +++ b/.github/workflows/health.yaml @@ -8,6 +8,6 @@ jobs: uses: dart-lang/ecosystem/.github/workflows/health.yaml@main with: checks: "changelog,do-not-submit,breaking,coverage,leaking" - ignore_coverage: "example/**,interop/**" + ignore_coverage: "example/,interop/" permissions: pull-requests: write From fb4bf99198ae2ff5d99a67f091f62b1598e66c1b Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 16 Dec 2024 14:56:30 +0100 Subject: [PATCH 5/9] without endings --- .github/workflows/health.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml index 1836a72f..a5c24511 100644 --- a/.github/workflows/health.yaml +++ b/.github/workflows/health.yaml @@ -8,6 +8,6 @@ jobs: uses: dart-lang/ecosystem/.github/workflows/health.yaml@main with: checks: "changelog,do-not-submit,breaking,coverage,leaking" - ignore_coverage: "example/,interop/" + ignore_coverage: "example,interop" permissions: pull-requests: write From 8191161d0f42ebfcbe8a06a6b1f6d573d53ad18f Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 16 Dec 2024 15:11:31 +0100 Subject: [PATCH 6/9] test new wf --- .github/workflows/health.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml index a5c24511..021f2878 100644 --- a/.github/workflows/health.yaml +++ b/.github/workflows/health.yaml @@ -5,7 +5,7 @@ on: types: [opened, synchronize, reopened, labeled, unlabeled] jobs: health: - uses: dart-lang/ecosystem/.github/workflows/health.yaml@main + uses: dart-lang/ecosystem/.github/workflows/health.yaml@519ab2527c7522a1fe7294f33f1ec69b2a49b0e5 with: checks: "changelog,do-not-submit,breaking,coverage,leaking" ignore_coverage: "example,interop" From 59c1e8f907ce6d4e0dfba681836bfe83debd7522 Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 16 Dec 2024 15:48:46 +0100 Subject: [PATCH 7/9] new version --- .github/workflows/health.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml index 021f2878..476fd357 100644 --- a/.github/workflows/health.yaml +++ b/.github/workflows/health.yaml @@ -5,9 +5,9 @@ on: types: [opened, synchronize, reopened, labeled, unlabeled] jobs: health: - uses: dart-lang/ecosystem/.github/workflows/health.yaml@519ab2527c7522a1fe7294f33f1ec69b2a49b0e5 + uses: dart-lang/ecosystem/.github/workflows/health.yaml@ef3d79a5da20da2e19e01d70cb9e8c1360311085 with: checks: "changelog,do-not-submit,breaking,coverage,leaking" - ignore_coverage: "example,interop" + ignore_coverage: "example/**,interop/**" permissions: pull-requests: write From 0a178625aada1674f6f80486afaae7c113e8f7c5 Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 16 Dec 2024 16:00:21 +0100 Subject: [PATCH 8/9] Works, use main now --- .github/workflows/health.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml index 476fd357..3ba41f30 100644 --- a/.github/workflows/health.yaml +++ b/.github/workflows/health.yaml @@ -5,7 +5,7 @@ on: types: [opened, synchronize, reopened, labeled, unlabeled] jobs: health: - uses: dart-lang/ecosystem/.github/workflows/health.yaml@ef3d79a5da20da2e19e01d70cb9e8c1360311085 + uses: dart-lang/ecosystem/.github/workflows/health.yaml@main with: checks: "changelog,do-not-submit,breaking,coverage,leaking" ignore_coverage: "example/**,interop/**" From 6efb6d3e4fa921504d4c45af525a4d6be8dc0eba Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 16 Dec 2024 16:09:03 +0100 Subject: [PATCH 9/9] Add changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 684f1d6a..273cc7c5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ * When the keep alive manager runs into a timeout, it will finish the transport instead of closing the connection, as defined in the gRPC spec. * Upgrade to `package:lints` version 5.0.0 and Dart SDK version 3.5.0. +* Upgrade `example/grpc-web` code. ## 4.0.1