Skip to content

Are there plans to mark marshallerWithRecursionLimit as stable? #11713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jebbench opened this issue Nov 27, 2024 · 4 comments · Fixed by #11884
Closed

Are there plans to mark marshallerWithRecursionLimit as stable? #11713

jebbench opened this issue Nov 27, 2024 · 4 comments · Fixed by #11884
Assignees
Labels

Comments

@jebbench
Copy link

Hi, we've got a protobuf message with a lot of recursion - we've been able to get it working by using the ProtoUtils.marshallerWithRecursionLimit method but it's currently marked as experimental.

Are there any plans to stabilize it?

PR that added the method:
https://github.com/grpc/grpc-java/pull/10094/files#diff-ffb45a421d722ff9c4d9266e36a27856e1c8c1686baa1b2b133aae602190eea2R67

Thanks,
James Bench

@kannanjgithub
Copy link
Contributor

kannanjgithub commented Nov 28, 2024

We can take it up for review during our next internal API review meeting on Dec 10.

@jebbench
Copy link
Author

@kannanjgithub did this get discussed?

Cheers

@shivaspeaks
Copy link
Member

@jebbench Yes, we are stabilizing this api.

@shivaspeaks shivaspeaks self-assigned this Feb 6, 2025
@jebbench
Copy link
Author

jebbench commented Feb 6, 2025

@shivaspeaks nice one, thanks very much.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants