Skip to content

Helper to get body parts from a streaming client response #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glbrntt opened this issue Jan 28, 2025 · 0 comments · Fixed by #2184
Closed

Helper to get body parts from a streaming client response #2183

glbrntt opened this issue Jan 28, 2025 · 0 comments · Fixed by #2184
Labels
good first issue Good for newcomers kind/usability Usability of generated code, ergonomics. 🆕 semver/minor Adds new public API. size/S Small task. (A couple of hours of work.)

Comments

@glbrntt
Copy link
Collaborator

glbrntt commented Jan 28, 2025

The StreamingClientResponse type has an accepted property which holds a result, the success case of which holds the Contents of the body of the response which in turn holds a bodyParts async sequence.

This isn't very ergonomic to get!

We should add a computed property called bodyParts to StreamingClientResponse which returns it to us (or throws).
@glbrntt glbrntt added good first issue Good for newcomers kind/usability Usability of generated code, ergonomics. size/S Small task. (A couple of hours of work.) 🆕 semver/minor Adds new public API. labels Jan 28, 2025
@glbrntt glbrntt mentioned this issue Jan 28, 2025
Merged
@gjcairo gjcairo mentioned this issue Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/usability Usability of generated code, ergonomics. 🆕 semver/minor Adds new public API. size/S Small task. (A couple of hours of work.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bodyParts computed prop to StreamingClientResponse gjcairo/grpc-swift
1 participant
@glbrntt